chore: Updated to Theia 1.31.1
#1662
Conversation
kittaakos
added
type: enhancement
kittaakos
force-pushed
the
theia-1.31.1
branch
3 times, most recently
from
e9fe466 to
2bf972c
Compare
kittaakos
force-pushed
the
theia-1.31.1
branch
from
2bf972c to
968bef8
Compare
kittaakos
force-pushed
the
theia-1.31.1
branch
from
968bef8 to
5e8a1f7
Compare
There was a problem hiding this comment.
UPDATE: Fixed by 3b8ed7f
To reproduce
- Start Arduino IDE.
- Wait for the 2.0.2 update notification dialog to appear.
🐛 The introductory sentence and changelog are missing from the dialog:
Expected behavior
Arduino IDE version
b5afe99 (tester build for 5e8a1f7)
Operating system
Windows
Operating system version
10
Additional context
The issue does not occur with any of the builds from the main branch (e.g., 2.0.2 with update notification triggered by changing to the "nightly" channel).
Closes #1655 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
force-pushed
the
theia-1.31.1
branch
from
7c851ca to
3b8ed7f
Compare
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
It should be working. As requested, I removed all UI of |
There was a problem hiding this comment.
UPDATE: fixed by f338106
To reproduce
- Select Tools > WiFi101 / WiFiNINA Firmware Updater from the Arduino IDE menus.
🙂 The dialog is populated as expected:
- Click the X icon in the dialog.
- Select Tools > WiFi101 / WiFiNINA Firmware Updater from the Arduino IDE menus.
🐛 The dialog is empty:
Expected behavior
"WiFi101 / WiFiNINA Firmware Updater" dialog is populated any time it is opened.
Arduino IDE version
0d9b47b (tester build for 9e042ae)
Operating system
Windows
Operating system version
10
Additional context
I see an error in the logs the second time I open the dialog:
2022-11-23T07:36:47.218Z root ERROR Error: Minified React error #409; visit https://reactjs.org/docs/error-decoder.html?invariant=409 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Yc.Qc.render.Yc.render (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:9548299)
at b.onUpdateRequest (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:2237015)
at b.e.processMessage (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:10434587)
at h (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:1457698)
at t (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:1456674)
at p (file:///C:/ide%202/rev/3-0d9b47b/resources/app/lib/bundle.js:2:1457869)
The issue does not occur with the build from the main branch.
- removed the firmware updater dialog widget - let the patched react dialog to render the content Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
|
There is another regression when creating a remote sketch. The spinner CSS selector has been removed from Theia. They kept the icon, but the missing-spinner.mp4 |
- it has been removed from Theia - aligned the DOM structure to previous the version when using widget Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
It should work now. Thank you for finding it.
This is also fixed. |
There was a problem hiding this comment.
UPDATE: fixed by ba16dcf
To reproduce
Equipment
- Any board that is configured for "user provided fields".
For example, the boards that can produce a network port:- MKR1000
- Any ESP8266-based board
- Any ESP32-based board
- MKR WiFi 1010 (advanced configuration is required)
- Nano 33 IoT (advanced configuration is required)
Steps
-
Connect and set up the board that is configured for "user provided fields".
- MKR1000: https://docs.arduino.cc/tutorials/mkr-1000-wifi/wifi-101-ota
- ESP8266-based board: - https://arduino-esp8266.readthedocs.io/en/latest/ota_updates/readme.html#application-example)
- ESP32-based board: File > Examples > ArduinoOTA > BasicOTA
- MKR WiFi 1010 / Nano 33 IoT: https://github.com/jandrassy/ArduinoOTA
- Select the board and port in the Arduino IDE.
- Select Sketch > Configure and Upload from the Arduino IDE menus.
🙂 The dialog is populated as expected:
- Click the X icon in the dialog.
- Select Sketch > Configure and Upload from the Arduino IDE menus.
🐛 The dialog is empty:
Expected behavior
"Configure and Upload" dialog is populated any time it is opened.
Arduino IDE version
f8b97fc (tester build for bfcb518)
Operating system
Windows
Operating system version
10
Additional context
I see an error in the logs the second time I open the dialog:
2022-11-28T04:58:55.930Z root ERROR Error: Minified React error #409; visit https://reactjs.org/docs/error-decoder.html?invariant=409 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at qc.Qc.render.qc.render (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:9548586)
at h.onUpdateRequest (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:2237982)
at h.e.processMessage (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:10434874)
at h (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:1458665)
at t (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:1457641)
at p (file:///C:/ide%202/rev/4-f8b97fc/resources/app/lib/bundle.js:2:1458836)
The issue does not occur with the build from the main branch.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
It should work now. Please take another look. Thank you! |
| @@ -0,0 +1,26 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Nice one @kittaakos ❤️
What if we run this script in a pre-commit with husky?
Also, I would probably rename it with .js extension. Or is there a reason why you did otherwise?
There was a problem hiding this comment.
What if we run this script in a pre-commit with
husky?
Good idea. Feel free to enhance it once it's on the main branch.
Also, I would probably rename it with
.jsextension. Or is there a reason why you did otherwise?
Thanks! As mentioned in the usage, I prefer to run it as an executable from a shell. This is how the bin hoisting works with yarn on POSIX. Check the files under ./node_modules/.bin as an example. Of course, it will fail from CMD.exe, but you can run it as node scripts\\sort-dependencies package.json. Or if you have a shell on Windows or using GitBash, ./scripts/sort-dependencies ./arduino-ide-extension/package.json works. Why do you think we should have the .js extension?
There was a problem hiding this comment.
Why do you think we should have the .js extension?
I suggested it to be consistent with other scripts we already have in the scripts folder, but I see your point. Maybe it would make sense to change the others into shell executable scripts (I'm not suggesting to do it in this PR).
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
|
UPDATE:
I found that adding this CSS rule would fix it: |
Follow-up: #1720 |
There was a problem hiding this comment.
Everything is working perfectly for me now on Windows and Linux.
I did a survey of the existing issues labeled "topic: theia"
PR resolves:
- Other ino files are not reflected in the window title #1656
- Indentation guides are always visible #1613
- Problem leaving "focus" mode #1550
- Missing translation in Theia's view-container context menu #1498
- Window title changes to "index.html" during reload #999
editor.hover.delaysetting not used by new windows #571
Partially resolves:
- Some Theia settings have no effect, problematic decriptions, or are ignored on startup #1077
- Everything reported in the issue is resolved except the following:
breadcrumbs.enabledhas no effectwindow.titleBarStylehas no effectworkbench.editor.highlightModifiedTabshas no effect
- Everything reported in the issue is resolved except the following:
Not resolved (but not expected to):
- Scrollbar width non-standard #436
- Chorded keyboard shortcuts not shown in menus #945
- Incorrect syntax highlighting after some preprocessor directives #1598
Thanks Akos!
The breadcrumbs feature has been forcefully removed from IDE2.
This has also been removed long ago.
I do not know what's this. I can create a follow-up with these items. |
|
Hi @kittaakos
If the settings are not expected to work, I think it is reasonable to explain that in #1077 and consider documenting the fact in the issue report to be sufficient. These settings are intended to be targeted exclusively to advanced users so we don't need to be so concerned about the user experience being polished. I don't know whether any further action to improve on the current situation is possible.
You can see the feature in effect in VS Code here (I am using the "Light+ (default light)" theme in the screenshot, but I also see the border in all the other themes I checked: "Dark (Visual Studio)", "Light (Visual Studio)", and "Dark High Contrast"):
|
|
Motivation
Change description
Other information
Switched to
@theia/*@1.31.1:p-queueversion to Theia.react@18+from Theia. Replaced theReactDOM#rendercalls withcreateRoot.react-virtualizedas a dependency. It was removed from Theia.react-select@5.6.0.IDE2 switched to the ellipses ((Reverted)...) icon fromfont-awesometocodicon.tabbar-toolbar-customization.mp4
Uploadon the toolbar,Debugtoolbar item,keydownevent and will spare the CPU. Avoid updating the status bar update is crucial for the language server's performance. The change was here. Steps to verify (Advanced!):status-bar-view-model.tswithCtrl/Cmd+P. Put a breakpoint to line 133.didChangeevent does not fire.Ctrl/Cmd+Kin the editor.monaco's key chords functionality activates.Open Sketch in New Window. If it works, you have helped verify that IDE2 windows can still pass arguments between each other without tricks in the IDE2 code-base.File>New Remote Sketchmenu item is correct, and you can see the accelerator next to it, it's working as expected.Reload Windowfrom the Command Palette,editor.bracketPairColorization.enabledtofalseby default.@theia/typehierarchyUI features from IDE2, (eclipse-theia/theia@16c88a5)webpack.config.jsfrom Git. They're not required anymore.depcheckplugin from packager.depcheckunreliably marked npm packages as unused and filtered them out. It's because Theia uses dynamicrequirecalls, and tools (such asdepcheck) cannot detect whether a module is needed at runtime.Closes #1655
Closes #1656
Reviewer checklist