feat: Updated to cortex-debug@1.5.1

[kittaakos]

Depends on #1662 ✅

---

Motivation

To use a more recent version of the cortex-debug VS Code extension.

Change description

Other information

Closes #246
Closes #1582

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[per1234]

UPDATE: Fixed by 7c3f1bf

An "**RTOS**" UI element was added to the menu bar.

There is no indication to the user that this is associated with the debugger. The fact that it is located on the menu bar, yet is not a menu is also unintuitive.

For now, I think the "Toggle RTOS View" command alone will be sufficient. If it later emerges that a significant portion of Arduino users want more convenient access to the view, perhaps some consideration can be given to exposing it in the IDE's primary UI in some way.

To reproduce

1. Start Arduino IDE

🐛 The menu bar contains an "RTOS" element:

Arduino IDE version

d3cec4f (tester build for 71d8482

Operating system

Windows

Operating system version

10

[kittaakos]

Thanks for reporting it. There is not much IDE2 can do but forcefully disable all the contributions the cortex-debug extension adds to VS Code/Theia. Is this what we want?

[kittaakos]

🐛 The menu bar contains an "RTOS" element:

It must be a Windows/Linux issue, as there is no RTOS menu on macOS.

[kittaakos]

There is no indication to the user that this is associated with the debugger. The fact that it is located on the menu bar, yet is not a menu is also unintuitive.

For now, I think the "Toggle RTOS View" command alone will be sufficient. If it later emerges that a significant portion of Arduino users want more convenient access to the view, perhaps some consideration can be given to exposing it in the IDE's primary UI in some way.

I removed the view. Let me know if you see a malfunction or notice other undesired things in the UI. Thanks!

Notes, I could see the RTOS view on Windows but not on macOS. I guess there is a bug upstream with the when context evaluation, and that's why the view and menu are visible on Windows but not on macOS. This requires further investigation in Theia.

[per1234]

I tested it on Windows and Linux and everything is working perfectly.

I verified it fixes #1582

Thanks Akos!

---

I do want to share some observations:

Required change to config for J-Link users

On Windows, when using a J-Link debug probe, if I set the serverpath field in debug_custom.json to point to JLinkGDBServer, starting the debugger fails with the notification:

Failed to launch undefined GDB Server: Timeout.

If I change the configuration to point to JLinkGDBServerCL instead, it works fine.

The reasons I was previously using JLinkGDBServer:

• It is specified in Arduino's official tutorial
• The same executable name can be used on Linux as well (astonishingly, JLinkGDBServer is actually a symlink to JLinkGDBServerCLExe on Linux, not JLinkGDBServerExe as you would expect)

Creation of files in sketch folder

I don't see this as really a problem, but I thought it was worth mentioning since previously no files were added.

---

If I do the following, a .vscode/.cortex-debug.registers.state.json is added to the sketch:

1. Start debugger.
2. Click "Reset device" on the debugger toolbar.
3. Click the "Stop" icon on the the debugger toolbar.

---

If I do the following, a .theia/settings.json is added to the sketch:

1. Start debugger.
2. Expand the "CORTEX REGISTERS" section of the DEBUG view.
3. Hover the mouse pointer over the "CORTEX REGISTERS" section toolbar.
4. Click the 0x icon.

---

[ubidefeo]

I like how the new debugger is behaving.
Skips the stop at entry point, no jumpToMain required anymore (deprecated), stops at first user breakpoint.
Also the variables in watch are updated correctly and in general seems to work well with JLink

LGTM