Restore support of breadcrumbs.enabled, window.titleBarStyle, and workbench.editor.highlightModifiedTabs advanced settings

[kittaakos]

Describe the request

Originally from here:

Partially resolves:

• Some Theia settings have no effect, problematic decriptions, or are ignored on startup #1077

  • Everything reported in the issue is resolved except the following:

    • breadcrumbs.enabled has no effect
    • window.titleBarStyle has no effect
    • workbench.editor.highlightModifiedTabs has no effect

Reply from here:

• breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

• window.titleBarStyle has no effect

This has also been removed long ago.

• workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

I can create a follow-up with these items.

Closing with the following comments from here:

breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

window.titleBarStyle has no effect

This has also been removed long ago.

If the settings are not expected to work, I think it is reasonable to explain that in #1077 and consider documenting the fact in the issue report to be sufficient. These settings are intended to be targeted exclusively to advanced users so we don't need to be so concerned about the user experience being polished.

I don't know whether any further action to improve on the current situation is possible.

workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

You can see the feature in effect in VS Code here (I am using the "Light+ (default light)" theme in the screenshot, but I also see the border in all the other themes I checked: "Dark (Visual Studio)", "Light (Visual Studio)", and "Dark High Contrast"):

---

Describe the current behavior

See the request description 👆

If restoring the lost features is trivial, this should be covered in this task. If it's not trivial or it causes performance issues, etc., then the reason for the missing features should be explained in #1077.

Arduino IDE version

5695fd8

Operating system

macOS, N/A

Operating system version

12.5.1

Additional context

Related to #1077

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[kittaakos]

• window.titleBarStyle has no effect

This is currently not supported by Theia on macOS. See here. The preference is connected to another setting value: window.menuBarVisibility. This preference is also disabled in Theia on macOS. Both preferences must be supported, or there is no way to show a custom title bar.

I put together a preview from the latest Theia sources, and somebody has to decide what IDE2 wants to do with the preference once they are available. Please look at how it works on resizing concerning overlay, menu, etc.:

custom-titlebar.mp4

• On macOS, the window control buttons must be moved to the left, and custom button styles are needed to provide a native look and feel.
• Figure out if IDE2 wants to support menus on the title bar. If not, the styling issues 👆 still be fixed on Windows and Linux.

[kittaakos]

• workbench.editor.highlightModifiedTabs has no effect

Upstream: eclipse-theia/theia#12185

[kittaakos]

From #2229 (comment):

Describe the request

the menu bar looks somewhat out of place if your theme's backgound differs from pure grey

Describe the current behavior

the menu bar is not effected by your theme

Arduino IDE version

2.2.1

Operating system

Windows

Operating system version

10