Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluate speed and efficiency improvements for rg.load and rg.log #2458

Closed
davidberenstein1957 opened this issue Mar 2, 2023 · 1 comment
Closed

evaluate speed and efficiency improvements for rg.load and rg.log #2458

davidberenstein1957 opened this issue Mar 2, 2023 · 1 comment
Assignees
@frascuchon
Labels
type: enhancement Indicates new feature requests
Milestone
v1.7.0

Comments

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Mar 2, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
rg.load and rg.log slow from time to time.

Describe the solution you'd like
as a quick fix:

Describe alternatives you've considered
N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Mar 2, 2023
@tomaarsen
Copy link
Contributor

tomaarsen commented Mar 2, 2023 •
edited
Loading

Your first quick fix is also described in #2454. I'll be tackling that issue today.
Edit: I now see that you linked to #2454 already, whoops.

@frascuchon frascuchon mentioned this issue May 1, 2023
Merged
@frascuchon frascuchon added this to the v1.7.0 milestone May 10, 2023
frascuchon added a commit that referenced this issue May 10, 2023
@frascuchon
Release v1.7.0 (#2817)
ddc29bf 
##
[1.7.0](v1.6.0...v1.7.0)

### Added

- add `max_retries` and `num_threads` parameters to `rg.log` to run data
logging request concurrently with backoff retry policy. See
[#2458](#2458) and
[#2533](#2533)
- `rg.load` accepts `include_vectors` and `include_metrics` when loading
data. Closes [#2398](#2398)
- Added `settings` param to `prepare_for_training`
([#2689](#2689))
- Added `prepare_for_training` for `openai`
([#2658](#2658))
- Added `ArgillaOpenAITrainer`
([#2659](#2659))
- Added `ArgillaSpanMarkerTrainer` for Named Entity Recognition
([#2693](#2693))
- Added `ArgillaTrainer` CLI support. Closes
([#2809](#2809))

### Changed

- Argilla quickstart image dependencies are externalized into
`quickstart.requirements.txt`. See
[#2666](#2666)
- bulk endpoints will upsert data when record `id` is present. Closes
[#2535](#2535)
- moved from `click` to `typer` CLI support. Closes
([#2815](#2815))
- Argilla server docker image is built with PostgreSQL support. Closes
[#2686](#2686)
- The `rg.log` computes all batches and raise an error for all failed
batches.
- The default batch size for `rg.log` is now 100.

### Fixed

- `argilla.training` bugfixes and unification
([#2665](#2665))
- Resolved several small bugs in the `ArgillaTrainer`.

### Deprecated

- The `rg.log_async` function is deprecated and will be removed in next
minor release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
3 participants
@frascuchon @davidberenstein1957 @tomaarsen