Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry and backoff behavior to rg.log/ rg.load #2533

Closed
davidberenstein1957 opened this issue Mar 14, 2023 · 1 comment
Closed

add retry and backoff behavior to rg.log/ rg.load #2533

davidberenstein1957 opened this issue Mar 14, 2023 · 1 comment
Assignees
Labels
type: enhancement Indicates new feature requests

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
logging is a bit fault prone but in a lot of my cases this logging could have been resolved using basic mitigation techniques.

Describe the solution you'd like
N.A.

Describe alternatives you've considered
N.A.

Additional context
encode/httpx#108 (comment)

@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Mar 14, 2023
@davidberenstein1957 davidberenstein1957 self-assigned this Mar 14, 2023
frascuchon added a commit that referenced this issue Apr 20, 2023
# Description

Allow log data batches concurrently

- Accept `num_threads` to log batches concurrently    
- Add retries when an `httpx.TransportError` occurs


Close partially #2533

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

TDB

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
frascuchon added a commit that referenced this issue May 10, 2023
##
[1.7.0](v1.6.0...v1.7.0)

### Added

- add `max_retries` and `num_threads` parameters to `rg.log` to run data
logging request concurrently with backoff retry policy. See
[#2458](#2458) and
[#2533](#2533)
- `rg.load` accepts `include_vectors` and `include_metrics` when loading
data. Closes [#2398](#2398)
- Added `settings` param to `prepare_for_training`
([#2689](#2689))
- Added `prepare_for_training` for `openai`
([#2658](#2658))
- Added `ArgillaOpenAITrainer`
([#2659](#2659))
- Added `ArgillaSpanMarkerTrainer` for Named Entity Recognition
([#2693](#2693))
- Added `ArgillaTrainer` CLI support. Closes
([#2809](#2809))

### Changed

- Argilla quickstart image dependencies are externalized into
`quickstart.requirements.txt`. See
[#2666](#2666)
- bulk endpoints will upsert data when record `id` is present. Closes
[#2535](#2535)
- moved from `click` to `typer` CLI support. Closes
([#2815](#2815))
- Argilla server docker image is built with PostgreSQL support. Closes
[#2686](#2686)
- The `rg.log` computes all batches and raise an error for all failed
batches.
- The default batch size for `rg.log` is now 100.

### Fixed

- `argilla.training` bugfixes and unification
([#2665](#2665))
- Resolved several small bugs in the `ArgillaTrainer`.

### Deprecated

- The `rg.log_async` function is deprecated and will be removed in next
minor release.
@davidberenstein1957
Copy link
Member Author

was handled in #2640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant