Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Enable search data from SearchEngine component #3017

Closed
frascuchon opened this issue May 30, 2023 · 0 comments · Fixed by #3037
Closed

[API] Enable search data from SearchEngine component #3017

frascuchon opened this issue May 30, 2023 · 0 comments · Fixed by #3037
Assignees

Comments

@frascuchon
Copy link
Member

Add support to the SearchEngine class to search records by text queries:

  • Simple text search: "q": "payment" or "q":"account number"
  • Per field search: "field": "text", "q": "payment" or "field": "prompt", "q": "generate code"
@frascuchon frascuchon linked a pull request May 31, 2023 that will close this issue
9 tasks
frascuchon added a commit that referenced this issue Jun 1, 2023
# Description

Adding `search` functionality to the `SearchEngine` class. This
functionality will be integrated with the new search endpoint in another
PR.

This search applies a basic search over all record fields, or by
selecting one of them.

### Update  

The search pagination will be tackled after the search endpoint
integration.

Closes #3017 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

New test cases have been added 

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
davidberenstein1957 pushed a commit that referenced this issue Jun 5, 2023
# Description

Adding `search` functionality to the `SearchEngine` class. This
functionality will be integrated with the new search endpoint in another
PR.

This search applies a basic search over all record fields, or by
selecting one of them.

### Update  

The search pagination will be tackled after the search endpoint
integration.

Closes #3017 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

New test cases have been added 

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
davidberenstein1957 pushed a commit that referenced this issue Jun 7, 2023
# Description

Adding `search` functionality to the `SearchEngine` class. This
functionality will be integrated with the new search endpoint in another
PR.

This search applies a basic search over all record fields, or by
selecting one of them.

### Update  

The search pagination will be tackled after the search endpoint
integration.

Closes #3017 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

New test cases have been added 

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants