Enable search data from SearchEngine component
#3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of github.com:argilla-io/argilla into 3017-api-enable-search-data-from-searchengine-component
for more information, see https://pre-commit.ci
gabrielmbmb
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
LGTM @frascuchon! Just two comments about creating some functions.
src/argilla/server/search_engine.py
Outdated
Comment on lines
169
to
175
| text_query = { | ||
| "combined_fields": { | ||
| "query": query.text.q, | ||
| "fields": [f"fields.{field.name}" for field in dataset.fields], | ||
| "operator": "and", | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we could move this to a function returning text_query as it would be easier to test with unit tests.
src/argilla/server/search_engine.py
Outdated
Comment on lines
178
to
185
| text_query = { | ||
| "match_phrase": { | ||
| f"fields.{query.text.field}": { | ||
| "query": query.text.q, | ||
| "operator": "and", | ||
| } | ||
| } | ||
| } |
|
I'll check what is happening with the failing tests, it is related to the changes I introduced in #2993. |
gabrielmbmb
approved these changes
Jun 1, 2023
* move text query build logic to a method * Rename `TextFieldQuery` to `TextQuery`
frascuchon
force-pushed
the
3017-api-enable-search-data-from-searchengine-component
branch
from
fcf6d1f
to
391f217
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3037 +/- ##
===========================================
+ Coverage 90.78% 90.80% +0.01%
===========================================
Files 208 208
Lines 11113 11166 +53
===========================================
+ Hits 10089 10139 +50
- Misses 1024 1027 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
frascuchon
deleted the
3017-api-enable-search-data-from-searchengine-component
branch
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 5, 2023
# Description Adding `search` functionality to the `SearchEngine` class. This functionality will be integrated with the new search endpoint in another PR. This search applies a basic search over all record fields, or by selecting one of them. ### Update The search pagination will be tackled after the search endpoint integration. Closes #3017 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** New test cases have been added **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 7, 2023
# Description Adding `search` functionality to the `SearchEngine` class. This functionality will be integrated with the new search endpoint in another PR. This search applies a basic search over all record fields, or by selecting one of them. ### Update The search pagination will be tackled after the search endpoint integration. Closes #3017 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** New test cases have been added **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
searchfunctionality to theSearchEngineclass. This functionality will be integrated with the new search endpoint in another PR.This search applies a basic search over all record fields, or by selecting one of them.
Update
The search pagination will be tackled after the search endpoint integration.
Closes #3017
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
New test cases have been added
Checklist