Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add question-answering support to the ArgillaTrainer #3320

Closed
davidberenstein1957 opened this issue Jul 4, 2023 · 0 comments
Closed

[FEATURE] add question-answering support to the ArgillaTrainer #3320

davidberenstein1957 opened this issue Jul 4, 2023 · 0 comments
Labels
area: trainer Indicates that an issue or pull request is related to the Argilla Trainer type: enhancement Indicates new feature requests
Milestone
v1.16.0

Comments

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jul 4, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The ArgillaTrainer defined in the docs, can be aligned with the common tasks described by HF, and some of them are missing.
I would like to see support for the https://huggingface.co/tasks/question-answering task.

Describe the solution you'd like
Ideally, this task should take an input and output text field.

Describe alternatives you've considered
N.A.

Additional context
Each task should have a defined task mapping schema and a defined representation in their associated framework.
@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Jul 4, 2023
@davidberenstein1957 davidberenstein1957 added the area: trainer Indicates that an issue or pull request is related to the Argilla Trainer label Aug 28, 2023
@davidberenstein1957 davidberenstein1957 mentioned this issue Sep 10, 2023
Merged
11 tasks
@davidberenstein1957 davidberenstein1957 added this to the v1.16.0 milestone Sep 11, 2023
davidberenstein1957 added a commit that referenced this issue Sep 11, 2023
@davidberenstein1957 @tomaarsen
feat: add training task for qna (#3740)
fdfa59b 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

I added a `TrainingTask.for_question_answering`. 

#3320

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] New feature (non-breaking change which adds functionality)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

tests/integration/client/feedback/training/test_trainer.py

**Checklist**

- [X] I added relevant documentation
- [X] I followed the style guidelines of this project
- [X] I did a self-review of my code
- [X] I made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [X] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [X] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)

---------

Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: trainer Indicates that an issue or pull request is related to the Argilla Trainer type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.16.0
Development

No branches or pull requests
2 participants
@davidberenstein1957 @gabrielmbmb