Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add training task for qna #3740

Merged
merged 13 commits into from
Sep 11, 2023

Conversation

davidberenstein1957
Copy link
Member

Description

I added a TrainingTask.for_question_answering.

#3320

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

tests/integration/client/feedback/training/test_trainer.py

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review September 10, 2023 21:15
Copy link
Contributor

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidberenstein1957 Great stuff, a few comments here and there, but I think this is looking good

docs/_source/guides/llms/practical_guides/fine_tune.md Outdated Show resolved Hide resolved
src/argilla/client/feedback/training/schemas.py Outdated Show resolved Hide resolved
docs/_source/guides/llms/practical_guides/fine_tune.md Outdated Show resolved Hide resolved
docs/_source/guides/llms/practical_guides/fine_tune.md Outdated Show resolved Hide resolved
src/argilla/client/feedback/training/schemas.py Outdated Show resolved Hide resolved
src/argilla/training/transformers.py Show resolved Hide resolved
src/argilla/training/transformers.py Outdated Show resolved Hide resolved
davidberenstein1957 and others added 4 commits September 11, 2023 14:06
Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
Co-authored-by: Tom Aarsen <37621491+tomaarsen@users.noreply.github.com>
added yield test
updated docstrings
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3740-ki24f765kq-no.a.run.app

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@davidberenstein1957 davidberenstein1957 merged commit fdfa59b into develop Sep 11, 2023
@davidberenstein1957 davidberenstein1957 deleted the feat/add-training-task-for-qna branch September 11, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants