You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
frascuchon opened this issue
Jul 4, 2023
· 0 comments
· Fixed by #3342
Assignees
Labels
area: apiIndicates that an issue or pull request is related to the Fast API server or REST endpointstype: bugIndicates an unexpected problem or unintended behavior
Describe the bug
Still for protected/non-searchable fields the metadata value limit truncation is applied. This could be skipped for this kind of field, letting users store more general info there.
Stacktrace and Code to create the bug
record.metadata["_protected"] = ... # large value hererg.log(record,dataset)
...
ds=rg.load(dataset)
forrinds:
r.metadata["_protected"] # The value will be truncated
Expected behavior
The protected metadata fields should be stored as is, without data truncation.
Environment:
Argilla Version [e.g. 1.0.0]: 1.10.0
ElasticSearch Version [e.g. 7.10.2]: 8.5.3
Docker Image (optional) [e.g. argilla:v1.0.0]:
Additional context
N/A
The text was updated successfully, but these errors were encountered:
frascuchon
added
type: bug
Indicates an unexpected problem or unintended behavior
area: api
Indicates that an issue or pull request is related to the Fast API server or REST endpoints
labels
Jul 4, 2023
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->
# Description
This PR reviews and improves the [protected metadata
field's](https://docs.argilla.io/en/latest/guides/log_load_and_prepare_data.html#protected-fields)
functionality:
- Values for protected fields won't be truncated
- Support for other than text content. Raw json dict are now supported.
Closes#3331Closes#3332
**Type of change**
(Please delete options that are not relevant. Remember to title the PR
according to the type of change)
- [X] Bug fix (non-breaking change which fixes an issue)
- [X] Improvement (change adding some improvement to an existing
functionality)
**How Has This Been Tested**
(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)
tested with a local instance
**Checklist**
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
Co-authored-by: Gabriel Martín Blázquez <gmartinbdev@gmail.com>
area: apiIndicates that an issue or pull request is related to the Fast API server or REST endpointstype: bugIndicates an unexpected problem or unintended behavior
Describe the bug
Still for protected/non-searchable fields the metadata value limit truncation is applied. This could be skipped for this kind of field, letting users store more general info there.
Stacktrace and Code to create the bug
Expected behavior
The protected metadata fields should be stored as is, without data truncation.
Environment:
Additional context
N/A
The text was updated successfully, but these errors were encountered: