Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Allow store other than text for protected metadata fields. #3332

Closed
frascuchon opened this issue Jul 4, 2023 · 0 comments · Fixed by #3342
Closed

[FEATURE] Allow store other than text for protected metadata fields. #3332

frascuchon opened this issue Jul 4, 2023 · 0 comments · Fixed by #3342
Assignees
@frascuchon
Labels
type: enhancement Indicates new feature requests
Milestone
v1.13.0

Comments

@frascuchon
Copy link
Member

Is your feature request related to a problem? Please describe.
Protected/non-searchable only allow store textual values. It would be great to store other than textual info, as dictionaries...

Describe the solution you'd like
Providing a JSON dictionary as value for protected metadata, the info should be stored without textual transformation.

Describe alternatives you've considered
N/A

Additional context
N/A
@frascuchon frascuchon added the type: enhancement Indicates new feature requests label Jul 4, 2023
@frascuchon frascuchon self-assigned this Jul 4, 2023
@frascuchon frascuchon added this to the v1.13 milestone Jul 4, 2023
@frascuchon frascuchon mentioned this issue Jul 5, 2023
Merged
10 tasks
frascuchon added a commit that referenced this issue Jul 6, 2023
@frascuchon @davidberenstein1957 @gabrielmbmb
feat: improve protected fields (#3342)
d49ae88 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

This PR reviews and improves the [protected metadata
field's](https://docs.argilla.io/en/latest/guides/log_load_and_prepare_data.html#protected-fields)
functionality:

- Values for protected fields won't be truncated
- Support for other than text content. Raw json dict are now supported.

Closes #3331 
Closes #3332  

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Bug fix (non-breaking change which fixes an issue)
- [X] Improvement (change adding some improvement to an existing
functionality)


**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

tested with a local instance 

**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
Co-authored-by: Gabriel Martín Blázquez <gmartinbdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

feat: improve protected fields argilla-io/argilla
1 participant
@frascuchon