Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: extend shortcuts to include alphabet for token classification #2339

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Enhancement: extend shortcuts to include alphabet for token classification #2339

merged 2 commits into from
Feb 28, 2023

Conversation

cceyda
Copy link
Contributor

@cceyda cceyda commented Feb 14, 2023

Description

This is a stop-gap solution to issue #1852
A more sophisticated solution can be found but in the mean time this solves the inconvenience when there are tags more than 10.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I added comments to my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@tomaarsen
Copy link
Contributor

I understand that this is designed as a simple temporary solution, but I want to point out that this will only work for the "default" QWERTY keyboard layout. Users on QWERTZ, AZERTY or others would likely find this unintuitive.

@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Feb 14, 2023
@cceyda
Copy link
Contributor Author

cceyda commented Feb 15, 2023

okay realized shortcuts are uppercased in code so changed that.

Also if anyone is looking for a quick custom shortcutkeys fix:
(chrome) using developer tools search for "1234567890" in js files, there should be 2.
then override, reload should work!

@dvsrepo
Copy link
Member

dvsrepo commented Feb 15, 2023

thanks so much @cceyda for the PR. I would vote to merge this and tackle the keyboard layout configuration mentioned by @tomaarsen as part of the new Dataset Setting feat #2003 (maybe not for the first version but for following releases, that would be configurable there). what do you think @leiyre @Amelie-V ?

Could you review this PR @leiyre ?

@frascuchon frascuchon added this to the v1.4.0 milestone Feb 22, 2023
leiyre
leiyre approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@leiyre leiyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@dvsrepo
Copy link
Member

dvsrepo commented Feb 27, 2023

@leiyre could this be merged already?

@frascuchon frascuchon merged commit 4a92b35 into argilla-io:develop Feb 28, 2023
@keithCuniah
Copy link
Contributor

keithCuniah commented Mar 6, 2023 •
edited
Loading

Hello everyone.
Just for information, as mention by @dvsrepo, this correction has also impact in dataset settings feature. See #2444. So I moved the solution to the the front ORM.

Second things, I was looking for a way to get the user keyboard layout dynamically (which could solve the problem pointed by @tomaarsen), and there is a keyboard API in javascript for that but it's experimental (see this link).
So when this API will be stable, it would be a nice solution to have dynamical shorcuts depending on the users keyboard.

keithCuniah pushed a commit that referenced this pull request Mar 6, 2023
feat: shortcut correction #2339
eb37c3b
@frascuchon frascuchon mentioned this pull request Mar 8, 2023
Merged
frascuchon added a commit that referenced this pull request Mar 9, 2023
@frascuchon
Release 1.4.0 (#2500)
cf75dd5 
# [1.4.0](v1.3.1...v1.4.0)
(2023-03-09)

### Features

* `configure_dataset` accepts a workspace as argument
([#2503](#2503))
([29c9ee3](29c9ee3)),
* Add `active_client` function to main argilla module
([#2387](#2387))
([4e623d4](4e623d4)),
closes [#2183](#2183)
* Add text2text support for prepare for training spark nlp
([#2466](#2466))
([21efb83](21efb83)),
closes [#2465](#2465)
[#2482](#2482)
* Allow passing workspace as client param for `rg.log` or `rg.load`
([#2425](#2425))
([b3b897a](b3b897a)),
closes [#2059](#2059)
* Bulk annotation improvement
([#2437](#2437))
([3fce915](3fce915)),
closes [#2264](#2264)
* Deprecate `chunk_size` in favor of `batch_size` for `rg.log`
([#2455](#2455))
([3ebea76](3ebea76)),
closes [#2453](#2453)
* Expose `batch_size` parameter for `rg.load`
([#2460](#2460))
([e25be3e](e25be3e)),
closes [#2454](#2454)
[#2434](#2434)
* Extend shortcuts to include alphabet for token classification
([#2339](#2339))
([4a92b35](4a92b35))


### Bug Fixes

* added flexible app redirect to docs page
([#2428](#2428))
([5600301](5600301)),
closes [#2377](#2377)
* added regex match to set workspace method
([#2427](#2427))
([d789fa1](d789fa1)),
closes [#2388]
* error when loading record with empty string query
([#2429](#2429))
([fc71c3b](fc71c3b)),
closes [#2400](#2400)
[#2303](#2303)
* Remove extra-action dropdown state after navigation
([#2479](#2479))
([9328994](9328994)),
closes [#2158](#2158)


### Documentation

* Add AutoTrain to readme
([7199780](7199780))
* Add migration to label schema section
([#2435](#2435))
([d57a1e5](d57a1e5)),
closes [#2003](#2003)
[#2003](#2003)
* Adds zero+few shot tutorial with SetFit
([#2409](#2409))
([6c679ad](6c679ad))
* Update readme with quickstart section and new links to guides
([#2333](#2333))
([91a77ad](91a77ad))


## As always, thanks to our amazing contributors!
- Documentation update: adding missing n (#2362) by @Gnonpi
- feat: Extend shortcuts to include alphabet for token classification
(#2339) by @cceyda
@frascuchon frascuchon mentioned this pull request Mar 21, 2023
Merged
frascuchon added a commit that referenced this pull request Mar 22, 2023
@frascuchon
Releases/1.5.0 (#2585)
7fb7eea 
## [1.5.0](v1.4.0...v1.5.0) -
2023-03-21

### Added

- Add the fields to retrieve when loading the data from argilla.
`rg.load` takes too long because of the vector field, even when users
don't need it. Closes
[#2398](#2398)
- Add new page and components for dataset settings. Closes
[#2442](#2003)
- Add ability to show image in records (for TokenClassification and
TextClassification) if an URL is passed in metadata with the key
\_image_url
- Non-searchable fields support in metadata.
[#2570](#2570)

### Changed

- Labels are now centralized in a specific vuex ORM called GlobalLabel
Model, see #2210. This model
is the same for TokenClassification and TextClassification (so both task
have labels with color_id and shortcuts parameters in the vuex ORM)
- The shortcuts improvement for labels
[#2339](#2339) have been moved
to the vuex ORM in dataset settings feature
[#2444](eb37c3b)
- Update "Define a labeling schema" section in docs.
- The record inputs are sorted alphabetically in UI by default.
[#2581](#2581)

### Fixes

- Allow URL to be clickable in Jupyter notebook again. Closes
[#2527](#2527)

### Removed

- Removing some data scan deprecated endpoints used by old clients. This
change will break compatibility with client `<v1.3.0`
- Stop using old scan deprecated endpoints in python client. This logic
will break client compatibility with server version `<1.3.0`
- Remove the previous way to add labels through the dataset page. Now
labels can be added only through dataset settings page.



### As always, thanks to our amazing contributors!
- Documentation update: tutorial for text classification models
comparison (#2426) by @embonhomme
- Docs: fix little typo (#2522) by @anakin87
- Docs: Tutorial on image classification (#2420) by @burtenshaw
@cceyda cceyda deleted the shortcut-extend branch April 25, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyre leiyre leiyre approved these changes

Assignees

@leiyre leiyre

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cceyda @tomaarsen @dvsrepo @keithCuniah @leiyre @frascuchon @davidberenstein1957