feat: Specific view for Dataset settings #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description This PR includes new description component and some class to simplify text styling Closes #2372 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** - [x] DatasetDescription **Checklist** - [x] I have merged the original branch into my forked branch - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works
…ecognai/rubrix into feature/front-dataset-settings
# Description Fetch and store dataset labels as proper label schema Closes #2210 **Type of change** - [x] remove obsolete code - _getDatasetSettings() in Dataset.js - initialize() in TextClassification.js and TokenClassification.js - initialize() call in the fetchByName() function in Dataset.js - [x] get labels from api for TextClassification and TokenClassification - [x] store labels as GlobalEntities in specific vuexorm (see "Ideal Orm" in this [link](https://www.notion.so/argilla/Refactoring-60c997e026644a28a2ff6a20c4cd90c3)) - [x] homogenized "AvailableRecords" (from TextClassificationHeader.vue) and "visibleEntities"(from TokenClassificationHeader) by the same vuexOrm query - [x] prepare vuexorm queries to be able to sort globalLabels by any param (by text, id, ...) and also ascending/descending - [x] add more feedbacks with toast component if label could be saved, there was a problem on save or if user try to add a label already saved Note : - With these updates, globalLabels from tokenclassification and textclassification have the same shape. M**eans they both have a "color_id" param which can be used to add color for labels in textClassification** - the connection between globalEntities and dataset table is with the "dataset_id" attribute from globalEntities. I didn't implement a oneToMany relationship to not performance problem as in Weak labelling implementation. This could be an idea of refactoring for later (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Refactor (change restructuring the codebase without changing functionality) - [x] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] TokenClassification task - [x] TextClassification task - N/A Text2Text task **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: keithCuniah <keithcuniah@gmail.comh>
keithCuniah
changed the title
# Description Edition label component Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. To merge after #2210 Closes #2371 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] Token classification - [x] Text classification - N/A Text2Text **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: keithCuniah <keithcuniah@gmail.comh>
# Description This PR includes new base-card component and dataset-delete component to allow delete dataset from settings and remove the old logic from de dataset list Closes #2370 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] Test for BaseCard component - [x] test for DatasetDeleteComponent **Checklist** - [x] I have merged the original branch into my forked branch - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works
# Description add generic layout for dataset settings page Closes #2368 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] all task **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - N/A I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: keithCuniah <keithcuniah@gmail.comh>
# Description This PR includes an icon in the dataset list to go to dataset settings See [#2003](#2003) **Type of change** - [x] New feature (non-breaking change which adds functionality) **Checklist** - [x] I have merged the original branch into my forked branch - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings
frascuchon
reviewed
Mar 1, 2023
Adding extra custom validation allow only admin/superuser dataset settings management. If for example, a non-admin user tries to upgrade/update label schema, this validation will return a 403 response.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2442 +/- ##
===========================================
- Coverage 93.53% 93.49% -0.04%
===========================================
Files 157 158 +1
Lines 7839 7861 +22
===========================================
+ Hits 7332 7350 +18
- Misses 507 511 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Fix the settings VERB to PATCH since settings can be partially updated (and deprecate the old one)
# Description create page dataset settings Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. Closes #2369 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] TokenClassification - [x] TextClassification - [x] Text2Text **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: keithCuniah <keithcuniah@gmail.comh> Co-authored-by: leire <leire@recogn.ai>
# Description This PR includes changes of styles and in the components logic after QA IMPORTANT: Before merge this branch, `feature/create-page-dataset-settings` must be merged **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: keithCuniah <keithcuniah@gmail.comh> Co-authored-by: keithCuniah <keithcuniah@gmail.com>
…ecognai/rubrix into feature/front-dataset-settings
…ecognai/rubrix into feature/front-dataset-settings
update changelog regarding dataset settings
frascuchon
changed the title
frascuchon
changed the title
frascuchon
approved these changes
Mar 16, 2023
frascuchon
added a commit
that referenced
this pull request
Mar 22, 2023
## [1.5.0](v1.4.0...v1.5.0) - 2023-03-21 ### Added - Add the fields to retrieve when loading the data from argilla. `rg.load` takes too long because of the vector field, even when users don't need it. Closes [#2398](#2398) - Add new page and components for dataset settings. Closes [#2442](#2003) - Add ability to show image in records (for TokenClassification and TextClassification) if an URL is passed in metadata with the key \_image_url - Non-searchable fields support in metadata. [#2570](#2570) ### Changed - Labels are now centralized in a specific vuex ORM called GlobalLabel Model, see #2210. This model is the same for TokenClassification and TextClassification (so both task have labels with color_id and shortcuts parameters in the vuex ORM) - The shortcuts improvement for labels [#2339](#2339) have been moved to the vuex ORM in dataset settings feature [#2444](eb37c3b) - Update "Define a labeling schema" section in docs. - The record inputs are sorted alphabetically in UI by default. [#2581](#2581) ### Fixes - Allow URL to be clickable in Jupyter notebook again. Closes [#2527](#2527) ### Removed - Removing some data scan deprecated endpoints used by old clients. This change will break compatibility with client `<v1.3.0` - Stop using old scan deprecated endpoints in python client. This logic will break client compatibility with server version `<1.3.0` - Remove the previous way to add labels through the dataset page. Now labels can be added only through dataset settings page. ### As always, thanks to our amazing contributors! - Documentation update: tutorial for text classification models comparison (#2426) by @embonhomme - Docs: fix little typo (#2522) by @anakin87 - Docs: Tutorial on image classification (#2420) by @burtenshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dataset settings feature
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Not merge before:
Closes #2003
Closes #2210
Closes #2368
Closes #2369
Closes #2370
Closes #2371
Closes #2372
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist