chore: added telemetry to ArgillaTrainer #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before tackling this I guess we should talk about whether adding telemetry in the Python client side is something we want to do @frascuchon, as for now we just have that in the API |
|
I briefly discussed this with @frascuchon and @dvsrepo before. For me it makes sense to do so in order to keep track of integrations like the trainer and the callbacks/plugins. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3336 +/- ##
===========================================
+ Coverage 90.45% 90.47% +0.01%
===========================================
Files 239 239
Lines 12828 12834 +6
===========================================
+ Hits 11604 11611 +7
+ Misses 1224 1223 -1
☔ View full report in Codecov by Sentry. |
chore: used get_telemetry_client method
|
@frascuchon I opted for moving telemetry to |
frascuchon
reviewed
Jul 6, 2023
frascuchon
reviewed
Jul 6, 2023
frascuchon
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Cool!!
I've included some comments
Also, maybe the changes referring to the training import issue should be removed, or wait to merge first #3346 ?
|
@frascuchon I assumed #3346 would be resolved during the patch. |
chore: remove client init if-statement
davidberenstein1957
deleted the
feat/3325-feature-add-telemetry-to-the-argillatrainer
branch
leiyre
pushed a commit
that referenced
this pull request
Jul 6, 2023
* develop: feat: disable concurrency tests GitHub (#3355) feat: improve protected fields (#3342) chore: added telemetry to ArgillaTrainer (#3336) Feat/update start page code (#3327) [DOCS] Added information about tests in developer documentation (#3147) # Conflicts: # docs/_source/_common/snippets/start_page.md # frontend/components/commons/datasets-list/DatasetsEmpty.vue
leiyre
pushed a commit
that referenced
this pull request
Jul 6, 2023
* develop: feat: disable concurrency tests GitHub (#3355) feat: improve protected fields (#3342) chore: added telemetry to ArgillaTrainer (#3336) Feat/update start page code (#3327) [DOCS] Added information about tests in developer documentation (#3147) # Conflicts: # docs/_source/_common/snippets/start_page.md # frontend/components/commons/datasets-list/DatasetsEmpty.vue
This was referenced Jul 27, 2023
frascuchon
added a commit
that referenced
this pull request
Jul 27, 2023
# Description This PRs fixes the `ModuleNotFoundError` and `ImportError` that occurred when trying to import something from `argilla.feedback` module. The first error was caused because in #3336 the telemetry was included in the `ArgillaTrainer`, but in the `argilla.utils.telemetry` module some optional dependencies used by the server were being imported. The second one was caused because the module in which `HuggingFaceDatasetMixin` (and from which `FeedbackDataset` is inheriting) class lives was importing classes from the `argilla.client.feedback.config` module, which was importing `pyyaml` in its root causing the `ImportError`. Closes #3468 **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** I've created a wheel of this branch, installed in a new virtual environment and I was able to import something `argilla.feedback` module without errors. **Checklist** - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <francis@argilla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
argilla.server.commons.telemetrytoargilla.utils.telemetrytelemetrytoArgillaTrainerfor Framework and NLP-taskCloses #3325
Type of change
How Has This Been Tested
N.A.
Checklist
N.A.