Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import errors when importing from argilla.feedback #3471

Merged
merged 8 commits into from
Jul 27, 2023
Merged

fix: import errors when importing from argilla.feedback #3471

merged 8 commits into from
Jul 27, 2023

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Jul 27, 2023 •
edited
Loading

Description

This PRs fixes the ModuleNotFoundError and ImportError that occurred when trying to import something from argilla.feedback module.

The first error was caused because in #3336 the telemetry was included in the ArgillaTrainer, but in the argilla.utils.telemetry module some optional dependencies used by the server were being imported.

The second one was caused because the module in which HuggingFaceDatasetMixin (and from which FeedbackDataset is inheriting) class lives was importing classes from the argilla.client.feedback.config module, which was importing pyyaml in its root causing the ImportError.

Closes #3468

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

I've created a wheel of this branch, installed in a new virtual environment and I was able to import something argilla.feedback module without errors.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb marked this pull request as ready for review July 27, 2023 14:03
@gabrielmbmb gabrielmbmb requested review from alvarobartt and frascuchon and removed request for alvarobartt July 27, 2023 14:03
@gabrielmbmb gabrielmbmb changed the title Fix/module not found error client fastapi fix: import errors when importing from argilla.feedback Jul 27, 2023
gabrielmbmb and others added 3 commits July 27, 2023 16:19
@gabrielmbmb
feat: move track_error unit test
75cb477
@gabrielmbmb @frascuchon
Update src/argilla/server/errors/api_errors.py
6667d88 
Co-authored-by: Francisco Aranda <francis@argilla.io>
@gabrielmbmb @frascuchon
Update src/argilla/server/errors/api_errors.py
0ba19ca 
Co-authored-by: Francisco Aranda <francis@argilla.io>
@gabrielmbmb gabrielmbmb force-pushed the fix/module-not-found-error-client-fastapi branch from 0f7819a to 0ba19ca Compare July 27, 2023 14:22
@frascuchon frascuchon merged commit d37ea7e into releases/1.13.3 Jul 27, 2023
13 checks passed
@frascuchon frascuchon deleted the fix/module-not-found-error-client-fastapi branch July 27, 2023 14:48
leiyre pushed a commit that referenced this pull request Jul 31, 2023
Merge branch 'develop' into styles/ui-fine-tuning
a36dcc7 
* develop:
  feat: field `PATCH` endpoint (#3421)
  feat: add dataset `PATCH` endpoint (#3402)
  fix: import errors when importing from `argilla.feedback` (#3471)
  feat: bump version to `0.13.3`
  docs: update example os listing users with python client (#3454)
  docs: Resolve typos, missing import (#3443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

@alvarobartt alvarobartt Awaiting requested review from alvarobartt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielmbmb @frascuchon