-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: field PATCH
endpoint
#3421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
added
type: enhancement
Indicates new feature requests
area: api
Indicates that an issue or pull request is related to the Fast API server or REST endpoints
labels
Jul 17, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3421 +/- ##
===========================================
+ Coverage 90.13% 90.15% +0.01%
===========================================
Files 233 248 +15
Lines 12493 13275 +782
===========================================
+ Hits 11261 11968 +707
- Misses 1232 1307 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
frascuchon
reviewed
Jul 26, 2023
frascuchon
reviewed
Jul 26, 2023
frascuchon
reviewed
Jul 26, 2023
Co-authored-by: Francisco Aranda <francis@argilla.io>
Co-authored-by: Francisco Aranda <francis@argilla.io>
frascuchon
reviewed
Jul 26, 2023
frascuchon
reviewed
Jul 27, 2023
Co-authored-by: Francisco Aranda <francis@argilla.io>
frascuchon
approved these changes
Jul 28, 2023
frascuchon
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: api
Indicates that an issue or pull request is related to the Fast API server or REST endpoints
type: enhancement
Indicates new feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs adds a new
PATCH /api/v1/fields/{field_id}
endpoint that allows to partially update a field of aFeedbackDataset
in the API. The attributes that can be updated using this new endpoint are:title
settings.use_markdown
To be able to update the
dict
column, it was needed to update theCRUDMixin.fill
method to detect if the column to be filled is adict
column. In that case, it will iterate the keys and values of the received value, and it will set the key and value of thedict
col one by one to avoid overriding the whole dict.Closes #3397
Type of change
How Has This Been Tested
I've tested it manually in a local environment and I've added unit tests.
Checklist