-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update example os listing users with python client #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliaElv
requested changes
Jul 27, 2023
docs/_source/tutorials/notebooks/labelling-tokenclassification-basics.ipynb
Outdated
Show resolved
Hide resolved
nataliaElv
reviewed
Jul 27, 2023
docs/_source/tutorials/notebooks/labelling-tokenclassification-basics.ipynb
Outdated
Show resolved
Hide resolved
…-basics.ipynb The following suggestion addresses these issues: - Listing users is limited to the role `owner`, but perhaps an `admin` might be doing the assignments. - We want to make sure that we only make assignments to users that have access to the dataset. Co-authored-by: Natalia Elvira <126158523+nataliaElv@users.noreply.github.com>
Sorry, one last change before approving the PR. In the block below # divide your dataset in chunks of the same length as the users list and make the assignments
n = len(users)
chunked_records = [ds[i:i + n] for i in range(0, len(ds), n)]
for chunk in chunked_records:
for idx, record in enumerate(chunk):
assignments[users[idx]['username']].append(record) |
No problem, that should be it then :) |
Thanks for the contribution @plaguss ! |
nataliaElv
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes #3453
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist