Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Resolve typos, missing import #3443

Merged
merged 1 commit into from
Jul 26, 2023
Merged

docs: Resolve typos, missing import #3443

merged 1 commit into from
Jul 26, 2023

Conversation

tomaarsen
Copy link
Contributor

Closes #3429

Hello!

Description

Resolves typos and a missing import as described by #3429

Type of change

  • Documentation update

How Has This Been Tested

I ran the snippet that I modified - it worked.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
  • Tom Aarsen

@tomaarsen tomaarsen added the type: documentation Improvements or additions to documentation label Jul 24, 2023
alvarobartt
alvarobartt approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tomaarsen for solving and @peppinob-ol for reporting! 👍🏻

@alvarobartt alvarobartt merged commit 4d04835 into argilla-io:main Jul 26, 2023
13 checks passed
@tomaarsen tomaarsen deleted the docs/typos_train branch July 26, 2023 12:39
@nataliaElv nataliaElv mentioned this pull request Jul 27, 2023
Closed
4 tasks
leiyre pushed a commit that referenced this pull request Jul 31, 2023
Merge branch 'develop' into styles/ui-fine-tuning
a36dcc7 
* develop:
  feat: field `PATCH` endpoint (#3421)
  feat: add dataset `PATCH` endpoint (#3402)
  fix: import errors when importing from `argilla.feedback` (#3471)
  feat: bump version to `0.13.3`
  docs: update example os listing users with python client (#3454)
  docs: Resolve typos, missing import (#3443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarobartt alvarobartt alvarobartt approved these changes

Assignees
No one assigned
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaarsen @alvarobartt