Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gzip compression in Redis by default #13458

Closed
crenshaw-dev opened this issue May 4, 2023 · 1 comment · Fixed by #13459
Closed

Enable gzip compression in Redis by default #13458

crenshaw-dev opened this issue May 4, 2023 · 1 comment · Fixed by #13459
Labels
enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Member

Summary

Compressing stuff in Redis saves a lot of network traffic and memory. The feature has been tested in large environments for a while. I think it's time to make it default.

Motivation

Saves money, serves our users better.

Proposal

Flip the default to gzip instead of none.
@crenshaw-dev crenshaw-dev added the enhancement New feature or request label May 4, 2023
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue May 4, 2023
@crenshaw-dev
feat: enable gzip compression in Redis by default (argoproj#13458)
5f51a0a 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev mentioned this issue May 4, 2023
Merged
crenshaw-dev added a commit that referenced this issue May 4, 2023
@crenshaw-dev
feat: enable gzip compression in Redis by default (#13458) (#13459)
460ecf3 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@crenshaw-dev
feat: enable gzip compression in Redis by default (argoproj#13458) (a…
c757b5b 
…rgoproj#13459)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@rumstead
Copy link
Member

rumstead commented Sep 1, 2023

Screenshot 2023-09-01 at 3 18 20 PM

Love this change

@rumstead rumstead mentioned this issue Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable gzip compression in Redis by default (#13458) crenshaw-dev/argo-cd
2 participants
@crenshaw-dev @rumstead