Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable gzip compression in Redis by default (#13458) #13459

Merged
merged 1 commit into from
May 4, 2023

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented May 4, 2023

🤖 Generated by Copilot at 5f51a0a

This pull request changes the default value of the redis-compress flag from none to gzip in various commands and configuration files that interact with Redis. The purpose of this change is to enable gzip compression for data sent to Redis by default, which can improve performance and reduce memory usage.

Closes #13458

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (8c5af34) 49.15% compared to head (5f51a0a) 49.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13459      +/-   ##
==========================================
- Coverage   49.15%   49.14%   -0.01%     
==========================================
  Files         248      248              
  Lines       42893    42893              
==========================================
- Hits        21082    21079       -3     
- Misses      19693    19695       +2     
- Partials     2118     2119       +1     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/dashboard.go 0.00% <0.00%> (ø)
util/cache/cache.go 51.18% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 460ecf3 into argoproj:master May 4, 2023
@crenshaw-dev crenshaw-dev deleted the redis-gzip-default branch May 4, 2023 21:56
@crenshaw-dev
Copy link
Member Author

@alexmt I think this is safe, but lmk if you have any concerns.

yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…rgoproj#13459)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable gzip compression in Redis by default
2 participants