Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make annotation based resource tracking the new default #13981

Open
jannfis opened this issue Jun 9, 2023 · 2 comments · May be fixed by #18961
Open

Make annotation based resource tracking the new default #13981

jannfis opened this issue Jun 9, 2023 · 2 comments · May be fixed by #18961
Labels
breaking/medium A possibly breaking change with medium impact component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement
Milestone

Comments

@jannfis
Copy link
Member

jannfis commented Jun 9, 2023

Summary

Argo CD should switch the default resource tracking method to the new annotation based resource tracking method.

Motivation

Label based resource tracking has proven to be very limited in the past due to the 63 characters limit of a label's value. The recently introduced annotation based resource tracking has significantly improved resource tracking for a couple of important use cases, e.g.

  • a controller makes a copy of a managed resource (or, uses such a managed resource as the source of other resources it creates) and in the process copies labels an annotations from the managed resource to the newly created resource
  • application tracking needs to consider more than just the application name (apps in any namespace is such an example), and thereby easily exceed the 63 character limit

People used to workaround some of these issue using sync options such as IgnoreExtraneous=true and Prune=false, but this is cumbersome and also not possible in any scenarios.

Proposal

Make annotation based (or even annotation+label) resource tracking the new default. This is a breaking change, therefore it should be changed on a major version bump.

@jannfis jannfis added the enhancement New feature or request label Jun 9, 2023
@jannfis jannfis added this to the v3.0 milestone Jun 9, 2023
@jannfis jannfis added the breaking/medium A possibly breaking change with medium impact label Jun 9, 2023
@terrytangyuan
Copy link
Member

+1

@terrytangyuan
Copy link
Member

I submitted a PR for this for v3.0 to open up some early discussions #18961

@alexmt alexmt added component:core Syncing, diffing, cluster state cache type:enhancement labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking/medium A possibly breaking change with medium impact component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement
Projects
None yet
3 participants