Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(breaking)!: Switch to use annotation based resource tracking as the default method. Closes #13981 #18961

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jul 5, 2024

Closes #13981. This is a draft PR for now to prevent from getting merged accidentally. This breaking change is intended for v3.0 but we'd like to open up an early discussion.

cc @jannfis and other @argoproj/argocd-approvers

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…the default method. Closes argoproj#13981

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link

bunnyshell bot commented Jul 5, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-m4zifh.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-m4zifh.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Jul 5, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@terrytangyuan terrytangyuan changed the title chore(breaking): Switch to use annotation based resource tracking as the default method. Closes #13981 !chore(breaking): Switch to use annotation based resource tracking as the default method. Closes #13981 Jul 5, 2024
@terrytangyuan terrytangyuan changed the title !chore(breaking): Switch to use annotation based resource tracking as the default method. Closes #13981 chore(breaking)!: Switch to use annotation based resource tracking as the default method. Closes #13981 Jul 7, 2024
@agaudreault agaudreault added this to the v3.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make annotation based resource tracking the new default
2 participants