Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(breaking)!: Switch to use annotation based resource tracking as the default method. Closes #13981 #18961

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(breaking)!: Switch to use annotation based resource tracking as the default method. Closes #13981 #18961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/user-guide/resource_tracking.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ data:

## Additional tracking methods via an annotation

>v3.0

The default resource tracking method has been changed to `annotation` after v3.0. Please see the rationale and discussions in [this issue](https://github.com/argoproj/argo-cd/issues/13981).
Note that this is a major change and can be intrusive if you have autosync enabled for many applications. If you'd like to reduce the impact, please see the following suggested steps for upgrading:

1. Disable autosync on your applications
1. Upgrade ArgoCD
1. Manually sync applications in batches
1. Re-enable autosync

>v2.2

To offer more flexible options for tracking resources and solve some of the issues outlined in the previous section Argo CD can be instructed to use the following methods for tracking:
Expand Down
2 changes: 1 addition & 1 deletion util/argo/resource_tracking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func NewResourceTracking() ResourceTracking {
func GetTrackingMethod(settingsMgr *settings.SettingsManager) v1alpha1.TrackingMethod {
tm, err := settingsMgr.GetTrackingMethod()
if err != nil || tm == "" {
return TrackingMethodLabel
return TrackingMethodAnnotation
}
return v1alpha1.TrackingMethod(tm)
}
Expand Down