-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge not found when app name contains a dot #15507
Comments
In the change made in #15468, it now throws an error if the Application name contains dots. This change is implemented at line 119 of argo-cd/server/badge/badge.go. Line 119 in 21672a2
The parameter name is validated using NameIsDNSLabel to ensure it adheres to the DNS 1123 label specification. If the name contains dot,it returns [must not contain dots]
However, as @pepe9012 mentioned, Application names can contain dots, which does not adhere to the DNS specification at a stand point of an applicaition name |
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
Hello, Sorry for writing here, but I have ArgoCD v2.10.7+b060053 and I have APPs of APPs with the following structure: Root APP called: test-app -> https://ARGOCD_URL/api/badge?name=test-app&revision=true Then, when I try to access the label of the root app I see it, but in the child APP, I can't see it. Both applications are in the same namespace. |
Describe the bug
Application badge is not found, if app name contains dot (
.
).Should be related to the changes in v2.8.4 #15468
To Reproduce
Application
which containes dot (.
) in it's name, e.g.:test.app
https://ARGOCD_URL/api/badge?name=test.app&revision=true
(answer will be 400 not found)Expected behavior
Application name can contains dots, and badge will work as it did in previous releases.
Version
v2.8.4
The text was updated successfully, but these errors were encountered: