-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid badge validation (#15507) #17580
Merged
ishitasequeira
merged 6 commits into
argoproj:master
from
agaudreault:fix-badge-name-validation
Mar 23, 2024
Merged
fix: invalid badge validation (#15507) #17580
ishitasequeira
merged 6 commits into
argoproj:master
from
agaudreault:fix-badge-name-validation
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
13 tasks
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
jannfis
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ishitasequeira
approved these changes
Mar 23, 2024
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the validation for the namespace and the name were reversed based on https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
Namespaces should be RFC-1123
Names should be a bit less restricted
Use common methods for validation
Closes #15507
Closes #15533
Checklist: