Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable writing k8s events #18205

Closed
tooptoop4 opened this issue May 14, 2024 · 7 comments · Fixed by #18441
Closed

Option to disable writing k8s events #18205

tooptoop4 opened this issue May 14, 2024 · 7 comments · Fixed by #18441
Assignees
@Jack-R-lantern
Labels
component:audit Information that helps use to track application history (app events, proj event etc) enhancement New feature or request good first issue Good for newcomers

Comments

@tooptoop4
Copy link

Summary

Environment variable/config to stop writing k8s events

Motivation

When i want to stop etcd filling up

Proposal

These parts of the code are writing k8s events which end up being stored in etcd:

argo-cd/util/argo/audit_logger.go

Lines 40 to 46 in 2162aaf

EventReasonStatusRefreshed = "StatusRefreshed"
EventReasonResourceCreated = "ResourceCreated"
EventReasonResourceUpdated = "ResourceUpdated"
EventReasonResourceDeleted = "ResourceDeleted"
EventReasonResourceActionRan = "ResourceActionRan"
EventReasonOperationStarted = "OperationStarted"
EventReasonOperationCompleted = "OperationCompleted"

argo-cd/server/application/application.go

Line 1901 in 2162aaf

s.logAppEvent(a, ctx, argo.EventReasonOperationStarted, reason)

argo-cd/docs/operator-manual/security.md

Line 190 in 2162aaf

$ kubectl get events

@tooptoop4 tooptoop4 added the enhancement New feature or request label May 14, 2024
@rumstead
Copy link
Member

related #10529

@tooptoop4 tooptoop4 mentioned this issue May 21, 2024
Closed
@pasha-codefresh pasha-codefresh added the good first issue Good for newcomers label May 22, 2024
@Jack-R-lantern
Copy link
Contributor

Jack-R-lantern commented May 28, 2024 •
edited
Loading

@pasha-codefresh I would like to work on this issue, can you assign me an issue?

@pasha-codefresh
Copy link
Member

Thank you @Jack-R-lantern

@Jack-R-lantern Jack-R-lantern mentioned this issue May 29, 2024
Merged
14 tasks
@Jack-R-lantern
Copy link
Contributor

@tooptoop4
Is it better to implement logging on/off based on the reason for the event?
Or should we implement on/off based on the kind?

@tooptoop4
Copy link
Author

i was interested in turning off all

@michalrysavy-ext95730
Copy link

Hi, many different controllers aggregates theirs events with count / firstTimestamp / lastTimestamp. It could solve some problems with growing etcd, could't it?
I'm not realy sure how it it works, but is it possible for ArgoCD?

@Jack-R-lantern
Copy link
Contributor

@michalrysavy-ext95730
Optionally, you can control the events that argocd generates.
You can turn off events that you deem unnecessary in the course of your operations.

@pasha-codefresh pasha-codefresh added the component:audit Information that helps use to track application history (app events, proj event etc) label Sep 17, 2024
gdsoumya pushed a commit that referenced this issue Sep 23, 2024
@Jack-R-lantern
feat: option to disable writing k8s events(#18205) (#18441)
eba559a 
* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* rebase

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this issue Sep 25, 2024
@Jack-R-lantern @ratulbasak
feat: option to disable writing k8s events(argoproj#18205) (argoproj#…
8b91837 
…18441)

* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* rebase

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
Jack-R-lantern added a commit to Jack-R-lantern/argo-cd that referenced this issue Nov 13, 2024
@Jack-R-lantern
feat: option to disable writing k8s events(argoproj#18205) (argoproj#…
028baf2 
…18441)

* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* rebase

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
gdsoumya pushed a commit that referenced this issue Nov 14, 2024
@Jack-R-lantern
feat: option to disable writing k8s events(#18205) (#18441) (#20788)
6a8cb6e 
* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
@Jack-R-lantern @adriananeci
feat: option to disable writing k8s events(argoproj#18205) (argoproj#…
20cb7d4 
…18441)

* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* rebase

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-R-lantern Jack-R-lantern

Labels
component:audit Information that helps use to track application history (app events, proj event etc) enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: option to disable writing k8s events(#18205) Jack-R-lantern/argo-cd
5 participants
@tooptoop4 @rumstead @pasha-codefresh @Jack-R-lantern @michalrysavy-ext95730