Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 2.12.0 only showing changes since 2.12.0-rc5, not since 2.11.x #19443

Closed
crenshaw-dev opened this issue Aug 8, 2024 Discussed in #19390 · 0 comments · Fixed by #20315 · May be fixed by #19470
Closed

Release notes for 2.12.0 only showing changes since 2.12.0-rc5, not since 2.11.x #19443

crenshaw-dev opened this issue Aug 8, 2024 Discussed in #19390 · 0 comments · Fixed by #20315 · May be fixed by #19470
Labels
component:cli Affects the Argo CD CLI type:enhancement

Comments

@crenshaw-dev
Copy link
Member

The release notes are generated by goreleaser.

We should see if there's goreleaser config to make sure that GA releases show all changes since the last non-rc release.

Discussed in #19390

Originally posted by kastl-ars August 6, 2024
Would it be possible to have the release notes on big updates (like 2.12.0) show the changes not only since the last RC release on this line? Most people using 2.11.x are more interested in what changed since the current 2.11 release. And having to go through six releases to collect all changes is... tedious.

Example:
https://github.com/argoproj/argo-cd/releases/tag/v2.12.0 only shows the changes since 2.12.0-rc5, not since 2.11.x.

Also, the full changelog is only compared to the last RC:
Full Changelog: https://github.com/argoproj/argo-cd/compare/v2.12.0-rc5...v2.12.0

Kind Regards,
Johannes
@alexmt alexmt added component:cli Affects the Argo CD CLI type:enhancement labels Aug 8, 2024
@juwon8891 juwon8891 mentioned this issue Aug 10, 2024
Open
@crenshaw-dev crenshaw-dev mentioned this issue Oct 9, 2024
Merged
crenshaw-dev added a commit that referenced this issue Oct 11, 2024
@crenshaw-dev
fix(ci): get correct previous release version for release notes (#19443…
b8f85c9 
…) (#20315)

* better release notes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* work on fork

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* don't do unnecessary stuff

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix path

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix path

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* help debug

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* refactor, clean up

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* use a workspace to avoid touching the main go.mod

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:cli Affects the Argo CD CLI type:enhancement
Projects
None yet
Milestone
No milestone
2 participants
@crenshaw-dev @alexmt