fix(ci): get correct previous release version for release notes (#19443)

[crenshaw-dev]

Fixes #19443

The script is overcomplicated, but the tests are simple.

I tested on my fork, and the code ran and got the correct tag for the test tag. I've probably missed edge cases, but at least this gives us something to iterate.

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.96%. Comparing base (4722a7f) to head (7ad5388).
Report is 18 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20315   +/-   ##
=======================================
  Coverage   55.95%   55.96%           
=======================================
  Files         322      322           
  Lines       44704    44704           
=======================================
+ Hits        25014    25017    +3     
+ Misses      17090    17087    -3     
  Partials     2600     2600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leoluz]

@crenshaw-dev Can you please confirm if the hack/get-previous-release/get-previous-version-for-release-notes_test.go gets executed during make test-local?

[crenshaw-dev]

@leoluz it doesn't. I think I'm okay with that? If anyone is monkeying with that file, I feel like they'll be aware enough to run the tests.

[nitishfy]

@crenshaw-dev sorry for the Ping. I'm curious to know how do you test the github actions workflow locally? Do you incorporate those changes to origin first and then raise a PR to upstream?

[crenshaw-dev]

@nitishfy I don't run them locally, I run them in my fork. I just remove any conditions that limit actions to running on argoproj/argo-cd, and generally that's enough to get it to run. In this case I also commented out a bunch of irrelevant steps so that I only had to run the one I cared about.

It always depends on precisely what you're running. Probably the easiest way to work is to pretend the argoproj/argo-cd repo doesn't exist and just make whatever changes are necessary to get things working on your fork. Then when it's time to put up a PR, just revert those changes one at a time, making sure they all make sense for argoproj/argo-cd.

[leoluz]

Approving for now. Maybe the test could be executed automatically as a small improvement.

[crenshaw-dev]

/cherry-pick release-2.13

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error b8f85c95006e638dce3eb9a87dc178c8370f393d into temp-cherry-pick-38c0dc-release-2.13

[crenshaw-dev]

Meh, will wait for 2.14.