-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add gitlab.SystemHookEvents to support Gitlab system events #12547
Merged
pasha-codefresh
merged 15 commits into
argoproj:master
from
kamuridesu:fix-gitlab-systemevent-webhook
Jun 27, 2023
Merged
fix: add gitlab.SystemHookEvents to support Gitlab system events #12547
pasha-codefresh
merged 15 commits into
argoproj:master
from
kamuridesu:fix-gitlab-systemevent-webhook
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [ISSUE argoproj#9625] Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12547 +/- ##
==========================================
- Coverage 49.76% 49.75% -0.01%
==========================================
Files 261 261
Lines 44653 44653
==========================================
- Hits 22222 22219 -3
- Misses 20248 20250 +2
- Partials 2183 2184 +1
☔ View full report in Codecov by Sentry. |
…ix-gitlab-systemevent-webhook Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
…amuridesu/argo-cd into fix-gitlab-systemevent-webhook Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
pasha-codefresh
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…oproj#12547) * fix: add gitlab.SystemHookEvents to support Gitlab system events Closes [ISSUE argoproj#9625] Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> * tests(gitlab.SystemHookEvents): fix tests for gitlab.SystemHookEvents Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> --------- Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…oproj#12547) * fix: add gitlab.SystemHookEvents to support Gitlab system events Closes [ISSUE argoproj#9625] Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> * tests(gitlab.SystemHookEvents): fix tests for gitlab.SystemHookEvents Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> --------- Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9625
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: