chore: set explicit package.json deps

[blakepettersson]

Related to #11006, all dependencies that are used within the app needs to be expressed in package.json, in case we ever want to use yarn berry or pnpm.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.21 🎉

Comparison is base (5662367) 48.98% compared to head (665b642) 49.19%.

❗ Current head 665b642 differs from pull request most recent head f97746e. Consider uploading reports for the commit f97746e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13483      +/-   ##
==========================================
+ Coverage   48.98%   49.19%   +0.21%     
==========================================
  Files         249      248       -1     
  Lines       43066    42909     -157     
==========================================
+ Hits        21094    21110      +16     
+ Misses      19864    19684     -180     
- Partials     2108     2115       +7     

see 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[crenshaw-dev]

Silly question: how does the UI build even work if we aren't explicitly mentioning all the dependencies we use?

[blakepettersson]

@crenshaw-dev for yarn and npm transitive dependencies works fine without needing to specify them in package.json, but when pnp mode is switched on for yarn >= 2 (and a similar caveat applies for pnpm) the build will fail (which was the case in #11006). See https://yarnpkg.com/getting-started/migration#before-we-start

With this PR and argoproj/argo-ui#367 I managed to get Argo to build with pnpm (I didn't try out yarn berry but can give that a shot as well).