chore: upgrade uuid #367
Merged
chore: upgrade uuid #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakepettersson
force-pushed
the
chore/upgrade-uuid
branch
from
b354c2c to
55a1182
Compare
Upgrading uuid should solve the build issues in argo-cd#11006. As is usual in JS land, a single upgrade has a bunch of follow-on effects, the main one being that node needs to be upgraded to at least `14.15` in order for this to build at all. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
chore/upgrade-uuid
branch
from
55a1182 to
fa988dc
Compare
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
chore/upgrade-uuid
branch
from
af6ec5e to
2fa37e4
Compare
10 tasks
8 tasks
crenshaw-dev
approved these changes
May 30, 2023
13 tasks
blakepettersson
added a commit
to blakepettersson/argo-ui
that referenced
this pull request
May 31, 2023
It seems like from the time when argoproj#367 was initially created, a newer version of react-toastify was released, which looks like it pulls in DefinitelyTyped/DefinitelyTyped#64464, which is a pretty breaking change. I haven't looked in depth, but I suspect if we were to upgrade to the latest version we'd need to upgrade React...
blakepettersson
added a commit
to blakepettersson/argo-ui
that referenced
this pull request
May 31, 2023
It seems like from the time when argoproj#367 was initially created, a newer version of react-toastify was released, which looks like it pulls in DefinitelyTyped/DefinitelyTyped#64464, which is a pretty breaking change. I haven't looked in depth, but I suspect if we were to upgrade to the latest version we'd need to upgrade React... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Merged
crenshaw-dev
pushed a commit
that referenced
this pull request
Jun 2, 2023
It seems like from the time when #367 was initially created, a newer version of react-toastify was released, which looks like it pulls in DefinitelyTyped/DefinitelyTyped#64464, which is a pretty breaking change. I haven't looked in depth, but I suspect if we were to upgrade to the latest version we'd need to upgrade React... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading uuid should solve the build issues in argoproj/argo-cd#11006. As is usual in JS land, a single upgrade has a bunch of follow-on effects, the main one being that node needs to be upgraded to at least
14.15in order for this to build at all.