fix: pin react-toastify #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakepettersson
force-pushed
the
fix/pin-react-toastify
branch
from
8cfce16
to
2648fb9
Compare
It seems like from the time when argoproj#367 was initially created, a newer version of react-toastify was released, which looks like it pulls in DefinitelyTyped/DefinitelyTyped#64464, which is a pretty breaking change. I haven't looked in depth, but I suspect if we were to upgrade to the latest version we'd need to upgrade React... Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
fix/pin-react-toastify
branch
from
2648fb9
to
dacd4a2
Compare
13 tasks
crenshaw-dev
approved these changes
Jun 2, 2023
blakepettersson
added a commit
to blakepettersson/argo-cd
that referenced
this pull request
Jun 2, 2023
Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
crenshaw-dev
pushed a commit
to argoproj/argo-cd
that referenced
this pull request
Jun 3, 2023
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like from the time when #367 was initially created, a newer version of react-toastify was released, which looks like it pulls in
DefinitelyTyped/DefinitelyTyped#64464, which is a pretty breaking change. I haven't looked in depth, but I suspect if we were to upgrade to the latest version we'd need to upgrade React...