Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Recursive Helm Values files detection (#15935) #15936

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat(ui): Recursive Helm Values files detection (#15935) #15936

merged 1 commit into from
Oct 19, 2023

Conversation

bagnaram
Copy link
Contributor

@bagnaram bagnaram commented Oct 12, 2023 •
edited
Loading

Closes: #15935
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@bagnaram bagnaram changed the title [#15935] Recursive Helm Values files detection feat: [#15935] Recursive Helm Values files detection Oct 12, 2023
@bagnaram bagnaram marked this pull request as ready for review October 12, 2023 22:26
@bagnaram bagnaram requested a review from a team as a code owner October 12, 2023 22:26
@bagnaram bagnaram marked this pull request as draft October 12, 2023 22:46
@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch 2 times, most recently from 1795b61 to e9bb10b Compare October 13, 2023 02:11
@bagnaram bagnaram marked this pull request as ready for review October 13, 2023 02:13
@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch 4 times, most recently from bf60d3c to 18186fa Compare October 13, 2023 16:27
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf80422) 49.53% compared to head (ef98941) 49.53%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15936   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         269      269           
  Lines       46583    46583           
=======================================
+ Hits        23073    23076    +3     
+ Misses      21238    21234    -4     
- Partials     2272     2273    +1
Files Coverage Δ
reposerver/repository/repository.go 60.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch from b23cc86 to eb2abe9 Compare October 16, 2023 18:00
@bagnaram bagnaram changed the title feat: [#15935] Recursive Helm Values files detection feat: [#15935] Recursive Helm Values files detection (alpha) Oct 16, 2023
jmeridth
jmeridth approved these changes Oct 19, 2023
View reviewed changes
reposerver/repository/repository.go Outdated Show resolved Hide resolved
@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch 2 times, most recently from e70b814 to 3869abe Compare October 19, 2023 15:42
@crenshaw-dev crenshaw-dev changed the title feat: [#15935] Recursive Helm Values files detection (alpha) feat(ui): Recursive Helm Values files detection (#15935) Oct 19, 2023
@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch 2 times, most recently from 877cf03 to 74e0c3f Compare October 19, 2023 18:56
@bagnaram
populate values files recursively
ef98941 
Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
@bagnaram bagnaram force-pushed the bagnaram/recursive-values-files branch from 74e0c3f to ef98941 Compare October 19, 2023 19:02
crenshaw-dev
crenshaw-dev approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@crenshaw-dev crenshaw-dev merged commit 973565e into argoproj:master Oct 19, 2023
22 checks passed
@bagnaram bagnaram deleted the bagnaram/recursive-values-files branch October 19, 2023 23:29
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@bagnaram @ymktmk
feat(ui): Recursive Helm Values files detection (argoproj#15935) (arg…
27d58ac 
…oproj#15936)

Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@bagnaram @jmilic1
feat(ui): Recursive Helm Values files detection (argoproj#15935) (arg…
fd55886 
…oproj#15936)

Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@bagnaram @vladfr
feat(ui): Recursive Helm Values files detection (argoproj#15935) (arg…
a4931cd 
…oproj#15936)

Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@bagnaram @tesla59
feat(ui): Recursive Helm Values files detection (argoproj#15935) (arg…
3ad91bf 
…oproj#15936)

Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@bagnaram @Hariharasuthan99
feat(ui): Recursive Helm Values files detection (argoproj#15935) (arg…
3f1de44 
…oproj#15936)

Signed-off-by: bagnaram <11695670+bagnaram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive Helm Values files detection
3 participants
@bagnaram @jmeridth @crenshaw-dev