fix(controller): Publish Work-queue Prometheus metrics #17017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonamkshenoy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17017 +/- ##
==========================================
+ Coverage 49.23% 49.26% +0.02%
==========================================
Files 274 273 -1
Lines 48113 48105 -8
==========================================
+ Hits 23689 23699 +10
+ Misses 22079 22062 -17
+ Partials 2345 2344 -1 ☔ View full report in Codecov by Sentry. |
|
Duplicate of #17013 |
|
Ahh yes, the PR seems to have made similar changes. However, I'm wondering if the |
This was referenced Jan 29, 2024
|
Seems to be worked on in this PR: #17013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16315 , #12241
Re-addresses: #7682 (PR: #8318)
The reason the work-queue metrics weren't being exported despite the init function introduced by this PR, is that the
init()function of theworkqueue.gowas being called before the argo'sinit(). These metrics were thus getting registered with the controller-runtimes metrics registry instead of the argo's one. And only the firstinit()registers the Prometheus registry with the work queues [refer doc].This PR includes the controller-runtime's registry's metrics.
This however comes at the cost of other unwanted metrics.
These unwanted metrics have been excluded as far as possible. Yet, they are quite a few.