-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register controller workqueue metrics correctly #8318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
fix-workqueue-metrics
branch
from
January 30, 2022 00:50
179216c
to
783a933
Compare
yeya24
commented
Jan 30, 2022
Codecov Report
@@ Coverage Diff @@
## master #8318 +/- ##
==========================================
- Coverage 41.91% 41.91% -0.01%
==========================================
Files 176 178 +2
Lines 22992 23003 +11
==========================================
+ Hits 9637 9641 +4
- Misses 11972 11979 +7
Partials 1383 1383
Continue to review full report at Codecov.
|
alexmt
requested changes
Jan 31, 2022
alexmt
requested changes
Feb 1, 2022
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
fix-workqueue-metrics
branch
from
February 1, 2022 04:39
783a933
to
327a33e
Compare
alexmt
approved these changes
Feb 1, 2022
Thank you! |
alexmt
pushed a commit
that referenced
this pull request
Feb 1, 2022
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
3 tasks
3 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Fixes: #7682.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Verification