Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register controller workqueue metrics correctly #8318

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 30, 2022

Signed-off-by: Ben Ye ben.ye@bytedance.com

Fixes: #7682.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Verification

image

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #8318 (327a33e) into master (85c114d) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8318      +/-   ##
==========================================
- Coverage   41.91%   41.91%   -0.01%     
==========================================
  Files         176      178       +2     
  Lines       22992    23003      +11     
==========================================
+ Hits         9637     9641       +4     
- Misses      11972    11979       +7     
  Partials     1383     1383              
Impacted Files Coverage Δ
controller/appcontroller.go 51.82% <ø> (ø)
controller/metrics/workqueue.go 12.50% <12.50%> (ø)
controller/metrics/metrics.go 80.13% <100.00%> (+0.13%) ⬆️
cmpserver/plugin/plugin.go 51.92% <0.00%> (ø)
cmpserver/plugin/plugin_unix.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c114d...327a33e. Read the comment docs.

controller/metrics/workqueue.go Outdated Show resolved Hide resolved
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@alexmt
Copy link
Collaborator

alexmt commented Feb 1, 2022

Thank you!

@alexmt alexmt merged commit 98bec43 into argoproj:master Feb 1, 2022
@yeya24 yeya24 deleted the fix-workqueue-metrics branch February 1, 2022 19:00
alexmt pushed a commit that referenced this pull request Feb 1, 2022
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application controller should export workqueue depth metrics
3 participants