-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) #18256
Conversation
Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
This seems trying to fix the same issue as #17560 |
Seems so. That PR looks stale but I will defer to maintainers as to which version you would like to go with. This is actively biting us, and workarounds are tricky for a variety of reasons, so whatever gets the issue fixed is fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks reasonable but I leave it to @jannfis since he looked at the other PR.
I prefer this one a bit because it seems simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I agree @todaywasawesome, the changes here look a bit simpler and accomplishing the same.
@RobinsonZ I do have some comments, please have a look.
Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
@jannfis Updated per your feedback. Let me know if any other changes are needed. |
Can this be cherry-picked into 2.11? |
/cherry-pick release-2.11 |
…syncs (issue #18237) (#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
…syncs (issue #18237) (#18256) (#18439) * Ensure truncated app label does not end in a special character * Move regex to global variable and add out of bounds check * Add test for out-of-bounds check --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com> Co-authored-by: Zack Robinson <zkislakrobinson@gmail.com>
…syncs (issue argoproj#18237) (argoproj#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…syncs (issue argoproj#18237) (argoproj#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
…syncs (issue argoproj#18237) (argoproj#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
…syncs (issue argoproj#18237) (argoproj#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Fixes #18237. Fixes #10110.
Checklist:
Does this PR require documentation updates?I've updated documentation as required by this PR.My new feature complies with the feature status guidelines.Optional. My organization is added to USERS.md.