fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) (cherry-pick #18256) #18439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…syncs (issue #18237) (#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
|
The DCO check seems to be failing because the squash commit was created with my personal email while the sign-offs are from my company email. I'm not sure how this should be fixed but if possible all commits here should be using |
pasha-codefresh
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) (#18256)
Signed-off-by: Zack Robinson robinsoz@arcesium.com
Signed-off-by: Zack Robinson robinsoz@arcesium.com
Signed-off-by: Zack Robinson robinsoz@arcesium.com
Signed-off-by: Zack Robinson robinsoz@arcesium.com