fix: revert #16416 - log app Spec along with event #18458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net>
jannfis
force-pushed
the
revert-16416-argo-1017
branch
from
92da6ba
to
30137d5
Compare
jannfis
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18458 +/- ##
==========================================
- Coverage 44.93% 44.91% -0.03%
==========================================
Files 354 354
Lines 47742 47694 -48
==========================================
- Hits 21454 21421 -33
+ Misses 23485 23477 -8
+ Partials 2803 2796 -7 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
approved these changes
May 30, 2024
rumstead
pushed a commit
to rumstead/argo-cd
that referenced
this pull request
Jun 6, 2024
…argoproj#18458) This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
timgriffiths
pushed a commit
to timgriffiths/argo-cd
that referenced
this pull request
Jun 11, 2024
…argoproj#18458) This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…argoproj#18458) This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net>
|
/cherry-pick release-2.11 |
crenshaw-dev
pushed a commit
that referenced
this pull request
Jun 13, 2024
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…argoproj#18458) This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…argoproj#18458) This reverts commit 820f4d8. Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
oleksandr-codefresh
added a commit
to codefresh-io/argo-cd
that referenced
this pull request
Sep 3, 2024
* add apiVersion so yaml applies properly in-cluster (#18282) Signed-off-by: condaatje <condaatje@users.noreply.github.com> * fix(ui): Add title for full content without clicking (issue #17600) (#18243) * fix: Add title for full content without clicking Signed-off-by: sunyeongchoi <suoung0716@gmail.com> * fix: apply ui lint Signed-off-by: sunyeongchoi <suoung0716@gmail.com> * fix: apply argo-ui Tooltip and define local variable Signed-off-by: sunyeongchoi <suoung0716@gmail.com> --------- Signed-off-by: sunyeongchoi <suoung0716@gmail.com> * feat: Adding the domain_hint as an optional field in OIDC configuration (#18214) * [18066] - Added DomainHint key in OIDCConfig struct Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * [18066] - Added DomainHint in options for grantType Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * [18066] - Auth0 readme.md --updated Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> --------- Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * chore(deps): bump library/node from 21.6.2 to 21.7.0 (#17446) Bumps library/node from 21.6.2 to 21.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * chore(ci): add /ui-test/ directory to dependabot.yml (#16235) Signed-off-by: Cheng Fang <cfang@redhat.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * fix(deps): upgrade otel dependency (#18285) Signed-off-by: Justin Marquis <justin@akuity.io> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> * chore(deps-dev): bump typescript from 4.1.3 to 5.4.5 in /ui-test (#18300) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.3 to 5.4.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](https://github.com/Microsoft/TypeScript/compare/v4.1.3...v5.4.5) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump prettier from 1.19.1 to 2.8.8 in /ui-test (#18302) Bumps [prettier](https://github.com/prettier/prettier) from 1.19.1 to 2.8.8. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/1.19.1...2.8.8) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 21.7.0 to 22.2.0 (#18297) Bumps library/node from 21.7.0 to 22.2.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update jest version (#18295) * update jest version in order to resolve https://github.com/argoproj/argo-cd/pull/14585/files Signed-off-by: pashakostohrys <pavel@codefresh.io> * update jest version in order to resolve https://github.com/argoproj/argo-cd/pull/14585/files Signed-off-by: pashakostohrys <pavel@codefresh.io> * update ts jest Signed-off-by: pashakostohrys <pavel@codefresh.io> * update ts jest Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> * chore(deps): bump chromedriver from 94.0.0 to 125.0.0 in /ui-test (#18303) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 94.0.0 to 125.0.0. - [Commits](https://github.com/giggio/node-chromedriver/compare/94.0.0...125.0.0) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump gitpod/workspace-full from `511cecd` to `f569b00` (#17565) * chore(deps-dev): bump dotenv from 8.2.0 to 16.4.5 in /ui-test (#18298) * docs(webhook): include installation instructions on Triggers and Templates page (#18304) * --- (#18312) * --- (#18311) * --- (#18315) updated-dependencies: - dependency-name: yarn dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/node from 14.14.14 to 20.12.12 in /ui-test (#18301) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.14 to 20.12.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * --- (#18307) updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add fullscreen prop (#18309) Signed-off-by: Fluder-Paradyne <121793617+Fluder-Paradyne@users.noreply.github.com> * --- (#18314) updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/mocha" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Implement KafkaConnector,KafkaBridge CRD health checks (#18316) * --- (#18318) updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Merge pull request from GHSA-9766-5277-j5hr * fix: Enable Redis authentication in the default installation Signed-off-by: May Zhang <may_zhang@intuit.com> * chore: fix git_test unit test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: pashakostohrys <pavel@codefresh.io> * Merge pull request from GHSA-9766-5277-j5hr * fix: Enable Redis authentication in the default installation Signed-off-by: May Zhang <may_zhang@intuit.com> * chore: fix git_test unit test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: pashakostohrys <pavel@codefresh.io> * docs: redis-ha registry change (#18329) * docs: redis-ha registry change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * update language Co-Authored-By: Avo Sepp <68659218+avo-sepp@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Avo Sepp <68659218+avo-sepp@users.noreply.github.com> * fix(ci): codecov (#18335) * fix(ci): codecov Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * build UI for frontend or backend Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use token, fail ci on error Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * chore(deps): bump golangci/golangci-lint-action from v3.7.0 to 6.0.1 (#18148) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix(ui): Fix jumpy "Source" panel when typing (issue #15961) (#18227) * Debounce `props.onAppChanged()` with a wait time of 500ms Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Increase debounce wait time to 800ms Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Fix linting error Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> --------- Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Update docs for azure workload identity cluster setup (#18357) Adds a missing step to the docs for declarative setup of an AKS cluster using workload identity for adding annotations to the service accounts. Signed-off-by: Mark Tallentire <lonelycooler@googlemail.com> * --- (#18353) updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * --- (#18349) updated-dependencies: - dependency-name: html-webpack-plugin dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * --- (#18345) updated-dependencies: - dependency-name: gitpod/workspace-full dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * --- (#18346) updated-dependencies: - dependency-name: assert dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang.org/x/net from v0.21.0 to v0.25.0 (#18176) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * --- (#18352) updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * --- (#18313) updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: "@types/selenium-webdriver" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) (#18256) * Ensure truncated app label does not end in a special character Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Move regex to global variable and add out of bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * Add test for out-of-bounds check Signed-off-by: Zack Robinson <robinsoz@arcesium.com> --------- Signed-off-by: Zack Robinson <robinsoz@arcesium.com> * feat: add ls-remote request fail metric (#18250) Added argocd_git_lsremote_fail_total metric. Increment this metric if a git ls-remote request fails. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> * docs: Clarify how Argo CD detects and uses Kustomize (#11417) * Add an example similar to the Helm topic This topic is missing a simple example like the next topic "Helm" to show how to define a Kustomize based application. https://argo-cd.readthedocs.io/en/stable/user-guide/helm/ Signed-off-by: Michael Chen <4326639+mcgitty@users.noreply.github.com> * Clarify how Argo CD detects and use Kustomize This description seems trivial to the designer of Argo CD, but it is a critical information for people learning Argo CD. Signed-off-by: Michael Chen <4326639+mcgitty@users.noreply.github.com> * Also mention 'path' in spec.source Signed-off-by: Michael Chen <4326639+mcgitty@users.noreply.github.com> * Update docs/user-guide/kustomize.md Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update docs/user-guide/kustomize.md Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Michael Chen <4326639+mcgitty@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io> * removing strikeout as it was populating special character issue #14139 (#14823) Signed-off-by: Rajesh Kriplani <rajesh.kriplani@gmail.com> * docs: Remove special characters from update doc (#18363) * Remove special characters from update doc Signed-off-by: Dan Garfield <dan@codefresh.io> * remove extra line * remove additional line --------- Signed-off-by: Dan Garfield <dan@codefresh.io> * --- (#18362) updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Bot] docs: Update Snyk reports (#18365) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> * fix: remove Egress NetworkPolicy for argocd-redis and argocd-redis-ha-haproxy (#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com> * feat: Added the comment to support CLI message to get extended output (#18253) * feat: Added the comment to support CLI message to get extended output #18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated proto and swagger #18226 Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> * feat: Updated manifest files Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> --------- Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> * chore(deps-dev): bump @types/react-paginate from 6.2.1 to 7.1.4 in /ui (#18373) Bumps [@types/react-paginate](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-paginate) from 6.2.1 to 7.1.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-paginate) --- updated-dependencies: - dependency-name: "@types/react-paginate" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump chromedriver from 125.0.0 to 125.0.1 in /ui-test (#18375) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 125.0.0 to 125.0.1. - [Commits](https://github.com/giggio/node-chromedriver/compare/125.0.0...125.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: automate mock generation v2 (#18371) * Add go:generate statements for mockery Signed-off-by: Will Roden <will@roden.cc> * revert whitespace change Signed-off-by: Will Roden <will@roden.cc> * go generate everything Signed-off-by: Will Roden <will@roden.cc> * make gogen Signed-off-by: Will Roden <will@roden.cc> * chore: upgrade to mockery v2.40.2 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Will Roden <will@roden.cc> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Will Roden <will@roden.cc> * chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (#18182) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](https://github.com/sigstore/cosign-installer/compare/e1523de7571e31dbe865fd2e80c5c7c23ae71eb4...59acb6260d9c0ba8f4a2f9d9b48431a222b68e20) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/react-autocomplete in /ui (#18374) Bumps [@types/react-autocomplete](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-autocomplete) from 1.8.6 to 1.8.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-autocomplete) --- updated-dependencies: - dependency-name: "@types/react-autocomplete" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/superagent from 4.1.21 to 8.1.6 in /ui (#17606) Bumps [@types/superagent](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/superagent) from 4.1.21 to 8.1.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/superagent) --- updated-dependencies: - dependency-name: "@types/superagent" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * chore(deps): bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#18376) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8...5742e2a039330cbb23ebf35f046f814d4c6ff811) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixes list generator cluster element (#18389) Signed-off-by: Dan Garfield <dan@codefresh.io> * chore(deps): bump chromedriver from 125.0.1 to 125.0.2 in /ui-test (#18399) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 125.0.1 to 125.0.2. - [Commits](https://github.com/giggio/node-chromedriver/compare/125.0.1...125.0.2) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix source ordering issue in manifest generation for multi-source app while using manifests and diff commands (#18395) * ci(lint): create .golangci.yaml (#18410) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * [Bot] docs: Update Snyk reports (#18413) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> * chore(deps): bump library/redis in /test/container (#18421) Bumps library/redis from `b32ea6e` to `01afb31`. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: enable misspell linter (#18412) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * fix: repo-server should allow not to skip hidden directories (#17957) * Update repository.go Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * add dir exclusion pattern Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> --------- Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> Co-authored-by: Bar <bar.ashkenazi@appsflyer.com> * chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 (#18440) Bumps [docker/login-action](https://github.com/docker/login-action) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](https://github.com/docker/login-action/compare/e92390c5fb421da1463c202d546fed0ec5c39f20...0d4c9c5ea7693da7b068278f7b52bda2a190a446) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: Fix "core" link in getting started (#18437) Signed-off-by: Philipp Erbelding <philipp@copythat.de> Signed-off-by: Philipp Erbelding <philipp.erbelding@cleverbridge.com> * feat(ui): list dependent resources in delete popup (#18116) * add icon in app table view Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use defaut menu in tree-grouped Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use default menu in pod views Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix custom delete actions Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * menu item in list Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix pod wrongly identified as root in network graph Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update docs error Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * call delete pod action if kind is pod Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * add logs action to pods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * delete in app details Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use managed instead of root for menu items Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * lint fix Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix lint again Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * feat(ui): list dependent resources in delete popup Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * linting Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * childs to children Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update ui dep Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * chore(deps): bump @fortawesome/fontawesome-free in /ui (#18397) Bumps [@fortawesome/fontawesome-free](https://github.com/FortAwesome/Font-Awesome) from 6.4.0 to 6.5.2. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](https://github.com/FortAwesome/Font-Awesome/compare/6.4.0...6.5.2) --- updated-dependencies: - dependency-name: "@fortawesome/fontawesome-free" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update ingress.md (#17766) Replace argocd-redis-ha-haproxy in the istio documentation with argocd-redis. Signed-off-by: Huseyin Caliskan <14217365+sakirma@users.noreply.github.com> * chore(deps-dev): bump sass-loader from 12.6.0 to 14.2.1 in /ui (#18451) Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 12.6.0 to 14.2.1. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack-contrib/sass-loader/compare/v12.6.0...v14.2.1) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/node from 20.12.12 to 20.12.13 in /ui-test (#18449) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.12 to 20.12.13. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump monaco-editor-webpack-plugin in /ui (#18450) Bumps [monaco-editor-webpack-plugin](https://github.com/microsoft/monaco-editor) from 7.0.1 to 7.1.0. - [Release notes](https://github.com/microsoft/monaco-editor/releases) - [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/monaco-editor/commits) --- updated-dependencies: - dependency-name: monaco-editor-webpack-plugin dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: removed legacy app tracking label (#13203) * feat: removed legacy app tracking label Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: refactor SetAppInstanceLabel func Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: refactor SetAppInstance func Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: refactor SetAppInstanceAnnotation func Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: refactored SetAppInstance() func Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * feat(issue/#17003): implement camel.apache.org/Integration CRD health checks (#17004) * feat: implement camel.apache.org/Integration CRD health checks Added custom health checks for Camel-K Integration CRDs Signed-off-by: mdebarros <migueld@debarros.me> * chore: cleanup up main health.lua Signed-off-by: mdebarros <miguel@debarros.me> --------- Signed-off-by: mdebarros <migueld@debarros.me> Signed-off-by: mdebarros <miguel@debarros.me> Co-authored-by: mdebarros <migueld@debarros.me> * feat: Kyriba is using ArgoCD (#18456) Signed-off-by: Nabil BENDAFI <nabilbendafi@users.noreply.github.com> * docs: remove the recommendation to optionally auth redis for secrets mgmnt (#18455) Signed-off-by: Tim Collins <tim@thecollins.team> * chore: add pipekit to argocd USERS (#18457) * chore: add pipekit to argocd USERS Signed-off-by: Tim Collins <tim@thecollins.team> * Trigger Build Signed-off-by: Tim Collins <tim@thecollins.team> --------- Signed-off-by: Tim Collins <tim@thecollins.team> * Revert "feat(server): log app Spec along with event (#16416)" (#18458) This reverts commit 820f4d861a7789f299143ed89816001091abf923. Signed-off-by: jannfis <jann@mistrust.net> * chore(deps): bump foundation-sites from 6.7.5 to 6.8.1 in /ui (#18462) Bumps [foundation-sites](https://github.com/foundation/foundation-sites) from 6.7.5 to 6.8.1. - [Release notes](https://github.com/foundation/foundation-sites/releases) - [Commits](https://github.com/foundation/foundation-sites/compare/v6.7.5...v6.8.1) --- updated-dependencies: - dependency-name: foundation-sites dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Update braces package to 3.0.3 (#18459) Signed-off-by: Keith Chong <kykchong@redhat.com> * chore: use redis secret when running locally (#18489) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#18492) Bumps library/busybox from `5eef5ed` to `9ae97d3`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix indentation (#18494) Signed-off-by: Mathieu Parent <math.parent@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * chore(deps-dev): bump @types/node from 20.12.13 to 20.14.1 in /ui-test (#18493) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.13 to 20.14.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/selenium-webdriver in /ui-test (#18476) Bumps [@types/selenium-webdriver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/selenium-webdriver) from 4.1.22 to 4.1.23. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/selenium-webdriver) --- updated-dependencies: - dependency-name: "@types/selenium-webdriver" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump chromedriver from 125.0.2 to 125.0.3 in /ui-test (#18477) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 125.0.2 to 125.0.3. - [Commits](https://github.com/giggio/node-chromedriver/compare/125.0.2...125.0.3) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Bot] docs: Update Snyk reports (#18471) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * feat: argocd cli support fish completion (#18484) * feat: argocd cli support fish completion Signed-off-by: Sn0rt <wangguohao.2009@gmail.com> * fix: update user doc for argocd fish completion Signed-off-by: Sn0rt <wangguohao.2009@gmail.com> --------- Signed-off-by: Sn0rt <wangguohao.2009@gmail.com> * fix: prevent preview changes sync (#18400) Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * chore: allow override of default e2e test args (#18415) Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr> * chore(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0 (#18504) * chore(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0 Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5.1.0 to 6.0.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/5742e2a039330cbb23ebf35f046f814d4c6ff811...286f3b13b1b49da4ac219696163fb8c1c93e1200) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * bump goreleaser version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update ingress.md (#18491) https://github.com/argoproj/argo-cd/issues/16611 Signed-off-by: bhargav joshi <bhargav.joshi@gmail.com> * feat: Consistent hashing with bounded loads algorithm for sharding (#16564) * Adds consistent hashing with bound loads sharding algorithm Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com> * Make the assignement consistent accross all clusters - The assignment or running of the algorithm has to be consistent across all the clusters. Changed the function to return a map where the consistent hash will be used to build the map - Modifications to the createConsistentHashsingWithBoundLoads function. This will create the map for cluster to shard. Note that the list must be consistent across all shards so that is why the cluster list must be sorted before going through the consistent hash algorithm Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com> * Extracting constant and simplifying boolean expression Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com> * Update docs: consistent-hashing sharding algorithm Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com> --------- Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com> * fix: enable bool-compare rule from testifylint linter (#18414) * docs: proposal for enhancing scoped repository credentials (#18290) * docs: proposal for enhancing scoped repository credentials Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: flesh out section on project matching Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: scope down proposal For the sake of time and simplicity, we will not do any modifications of `repo-creds` secrets for this proposal. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: added feedback Feedback from contributors' meeting, part one. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: modification date Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove use cases Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: spec update Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: clarify backward-compatability Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: further clarification of backwards compatibility Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Update docs/proposals/project-scoped-repository-enhancements.md Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Update docs/proposals/project-scoped-repository-enhancements.md Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Update docs/proposals/project-scoped-repository-enhancements.md Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: behavior in line with current impl Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add reviewers Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Update docs/proposals/project-scoped-repository-enhancements.md Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: changes git client to resolve semantic versioning tags (#17566) * feat: changes git client to resolve semantic versioning tags Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * docs: update documentation Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * feat: simplify `resolveSemverRevision` method Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * chore: add two more test cases Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * chore: update `resolveSemverRevision` behavior Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * chore: add end to end test Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * chore: fix end to end test Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * chore: improve semver constraint e2e testing Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> --------- Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br> * Move code around to fix commit attribution. (#18515) Signed-off-by: Paul Larsen <pnvlarsen@gmail.com> * chore(deps-dev): bump @types/node from 20.14.1 to 20.14.2 in /ui-test (#18519) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.1 to 20.14.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump bitnami/kubectl in /test/container (#18517) Bumps bitnami/kubectl from `0aef4af` to `cdca6c1`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: update notifications troubleshooting-errors doc with custom secret (#18490) * Update troubleshooting-errors with custom secret Adding section for a custom secret Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com> * Update troubleshooting-errors.md Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com> --------- Signed-off-by: Nicholas Hawkes <hawkesn@gmail.com> * Merge pull request from GHSA-87p9-x75h-p4j2 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Merge pull request from GHSA-3cqf-953p-h5cp * fix: prevent enumerating by cluster name, return exact error for case when cluster exists and not Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: prevent cluster enumeration by name Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: prevent cluster enumeration by name Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter and add unit test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter and add unit test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter and add unit test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter and add unit test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter and add unit test Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix(applicationset): prevent applicationset progressive sync from stalling in pending (#17296) * fix(applicationset): prevent applicationset progressive sync from stalling in pending Signed-off-by: wparr-circle <william.parr@circle.com> * chore: remove out of date misleading comment Signed-off-by: William Parr <william.parr@circle.com> * chore: add reflect package removed by merge Signed-off-by: wparr-circle <william.parr@circle.com> --------- Signed-off-by: wparr-circle <william.parr@circle.com> Signed-off-by: William Parr <william.parr@circle.com> * test: fix e2e tests after GHSA-3cqf-953p-h5cp (#18543) * fix: github.com/cloudflare/circl High CVE (#18538) Signed-off-by: Justin Marquis <justin@akuity.io> * chore: bump go version to 1.22.4 (#18539) Signed-off-by: Justin Marquis <justin@akuity.io> * fix(ci): run codegen for docs changes (#18536) * fix(ci): run codegen for docs changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * test docs change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert test change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> * chore(deps): upgrade helm to 5.4.2 (#18556) Signed-off-by: Justin Marquis <justin@akuity.io> * chore: enable len and empty rules from testifylint linter (#18516) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * feat: project-scoped repository credential improvements (#18388) * feat: project-scoped repo cred improvements Implementation of #18290 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: missed a test Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * wip project key changes Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: update mocks Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix tests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: equivalence even if project is empty Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: wip delete Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * refactor: remove repositorydb Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: improve logging Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: pass project to getrepository Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing test Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: compare with project secret instead of app secret Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: get repository needs same logic as delete Need to update the spec accordingly. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * feat: add project flag to repo rm command Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: fix failing test Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: more failing tests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor cleanups Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: propagate project from ui Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add new test cases Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: code review, improve formulation Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * refactor: address cr feedback Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * [Bot] docs: Update Snyk reports (#18561) Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> * chore: enable goimports linter (#18564) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable errorlint linter on `pkg` folder (#18563) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable error-nil rule from testifylint linter (#18544) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * fix: sonar scanner #18513 (#18559) * fix: sonar scanning Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * updating action to use sha Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix: InferenceService healthy condition change (#18340) * fix: InferenceService healthy condition change With Kerver upgrade to v12.0, Inference graphs and Inference Services can be deployed in raw mode that reduces overall resources that gets created. Several knative resource dependency has been reduced. There by reduces the number of conditions in the status field as well. Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com> * fix: addressed code review comments Protected new changes with a specific kserve v12 onwards Rawdeployment mode while keeping the existing resource checks as is. Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com> * Update resource_customizations/serving.kserve.io/InferenceService/health.lua Co-authored-by: Rachit Chauhan <rachitchauhan43@gmail.com> Signed-off-by: bmopuri <bharath.mopuri@gmail.com> --------- Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com> Signed-off-by: bmopuri <bharath.mopuri@gmail.com> Co-authored-by: Mopuri, Bharath <bharath_mopuri@intuit.com> Co-authored-by: Rachit Chauhan <rachitchauhan43@gmail.com> * chore(deps): upgrade haproxy to 2.6.17-alpine (#18574) Signed-off-by: Justin Marquis <justin@akuity.io> * chore(ci): ignore test files from sonar monitoring (#18573) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * chore: enable errorlint linter on `cmd` folder (#18578) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable expected-actual rule from testifylint linter (#18575) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: add sonar-project.properties to cd in CODEOWNERS (#18577) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat(application-controller): Add support for rollback multi-source applications (#14124) * feat(application-controller): Add support for rollback multi-source applications Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * regenerate codegen after rebase Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix front linting Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update test Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update codegen Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update server/application/application.go Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * apply feedback Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix errors Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add support for switching between single and multi Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix dereference issue Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * remove unnecesary code Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Rebase master Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix reference Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add a comment Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> * chore(deps): bump docker/build-push-action from 5.3.0 to 5.4.0 (#18583) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/2cdde995de11925a030ce8070c3d77a52ffcf1c0...ca052bb54ab0790a636c9b5f226502c73d547a25) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: enable errorlint linter on util folder (#18588) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable gofumpt and whitespace linters (#18567) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable compare and nil-compare rules from testifylint linter (#18581) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable errorlint linter on controller folder (#18596) * chore: enable errorlint linter on controller folder Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update cache.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update cache.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * docs: Add Syself to USERS.md (#18593) Signed-off-by: janiskemper <janis.kemper@syself.com> * feat(appset): appset git generator verifies GPG signatures (#18545) * feat(appset): appset git generator verifies GPG signatures Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix unit tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix generated code Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * add check for signatures in project and fix tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * add e2e tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * address golang ci lint issue Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix golangci lint Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * rebase and resolve conflicts Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * chore(deps): bump library/node from 22.2.0 to 22.3.0 in /ui-test (#18609) Bumps library/node from 22.2.0 to 22.3.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.2.0 to 22.3.0 in /test/container (#18610) Bumps library/node from 22.2.0 to 22.3.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 22.2.0 to 22.3.0 (#18611) Bumps library/node from 22.2.0 to 22.3.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump braces from 3.0.2 to 3.0.3 in /ui-test (#18584) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ui): pod log view dark mode toggle (#18424) * moon-button-fixed Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * reverted Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * as it is Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * chore: enable errorlint linter on applicationset folder (#18618) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable errorlint linter on server folder (#18624) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable require-error rule from testifylint linter (#18621) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore: enable errorlint linter on cmpserver and reposerver folders (#18629) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * chore(deps): bump library/golang from `969349b` to `0f76912` (#18628) Bumps library/golang from `969349b` to `0f76912`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump bitnami/kubectl in /test/container (#18626) Bumps bitnami/kubectl from `cdca6c1` to `e704ebf`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump chromedriver from 125.0.3 to 126.0.0 in /ui-test (#18627) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 125.0.3 to 126.0.0. - [Commits](https://github.com/giggio/node-chromedriver/compare/125.0.3...126.0.0) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: updated yarn version (#18631) With the Dependabot Node bump in #18610, the test container no longer builds due to a change in Yarn version. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * feat: Support Rollback multi-source apps; Follow-up to PR 14124 (#18615) * feat: Support Rollback multi-source apps; Follow-up to PR 14124 Signed-off-by: Keith Chong <kykchong@redhat.com> * Common up code Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> * fix: Correction in Rocket.chat documentation (#18498) * Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Updated go.mod Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Revert "Updated go.mod" This reverts commit a6466530041cb541fca020024c77047dcfed2ba5. Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Updated go.mod Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> --------- Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * chore(deps): bump library/golang in /test/container (#18625) Bumps library/golang from `969349b` to `0f76912`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> * feat: adding gocover to e2e tests (#18130) (#18537) * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * try putting profiles in different directories Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * does this upload the whole directory? Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * create directories and only run one test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * shut everything down before uploading coverage Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't fail on goreman failure Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * sleep 30 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * always upload server output Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix: implement graceful shutdown for api server Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Shutdown servers in parallel Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * add noop shutdown function on api server constructor Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix waitgroup Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * more attempts to gracefully shut down Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * cleanup Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert graceful shutdown work, needs more work Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more graceful shutdown cleanup Sign…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #16416 (see #18310 (comment))
Closes #18310