feat: Add custom resource health for flux resources

[adberger]

As shortly discussed here: #18888
This is the second PR to implement custom resource health for flux resources.

Note: Since I couldn't get some resources to get in the Progressing state, I couldn't write proper tests for them:

• ImagePolicy
• ImageRepository
• ImageUpdateAutomation
• Receiver
• Bucket
• GitRepository
• HelmChart
• HelmRepository
• OCIRepository

All checks were written based on the documenation of Flux, e.g. https://fluxcd.io/flux/components/kustomize/kustomizations/#conditions

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[todaywasawesome]

Looks good. These are always a little tricky to review just because there's so much but overall I don't see any issues.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.65%. Comparing base (30a1623) to head (90f92c2).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #19082   +/-   ##
=======================================
  Coverage   50.65%   50.65%           
=======================================
  Files         315      315           
  Lines       43347    43347           
=======================================
  Hits        21959    21959           
  Misses      18885    18885           
  Partials     2503     2503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adberger]

Looks good. These are always a little tricky to review just because there's so much but overall I don't see any issues.

Thank you :)
I'll gladly fix any issues popping up

[crenshaw-dev]

@adberger I looks like maybe the health checks don't show the paused status? Just did a quick test, when I suspend a resource, it's just marked as healthy. I'm not sure if that's intentional.

[adberger]

@adberger I looks like maybe the health checks don't show the paused status? Just did a quick test, when I suspend a resource, it's just marked as healthy. I'm not sure if that's intentional.

@crenshaw-dev that's right.
AFAIK Argo CD "only" knows Healthy, Progressing and Degraded.
What state should a suspended Flux respurce show in your opinion?

[crenshaw-dev]

I think "Suspended" might actually be a good status. It's lightly documented here: https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-1-define-a-custom-health-check-in-argocd-cm-configmap

Suspended - the resource is suspended and waiting for some external event to resume (e.g. suspended CronJob or paused Deployment)

[adberger]

I think "Suspended" might actually be a good status. It's lightly documented here: https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-1-define-a-custom-health-check-in-argocd-cm-configmap

Suspended - the resource is suspended and waiting for some external event to resume (e.g. suspended CronJob or paused Deployment)

Oh, I didn't know that "Suspended" exists :D
I'll try to submit a PR next week, thanks.

[crenshaw-dev]

Yeah it's deep lore tbh. Thanks!

[adberger]

@crenshaw-dev let me know what you think about it: #19508 :)