-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add custom resource health for flux resources #19082
Conversation
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. These are always a little tricky to review just because there's so much but overall I don't see any issues.
Signed-off-by: Dan Garfield <dan@codefresh.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19082 +/- ##
=======================================
Coverage 50.65% 50.65%
=======================================
Files 315 315
Lines 43347 43347
=======================================
Hits 21959 21959
Misses 18885 18885
Partials 2503 2503 ☔ View full report in Codecov by Sentry. |
Thank you :) |
* feat: Add custom resource health for flux resources Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> * chore: Update upgrade docs Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> --------- Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io>
* feat: Add custom resource health for flux resources Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> * chore: Update upgrade docs Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> --------- Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Vegard Færgestad <vegardf@mnemonic.no>
@adberger I looks like maybe the health checks don't show the |
@crenshaw-dev that's right. |
I think "Suspended" might actually be a good status. It's lightly documented here: https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-1-define-a-custom-health-check-in-argocd-cm-configmap
|
Oh, I didn't know that "Suspended" exists :D |
Yeah it's deep lore tbh. Thanks! |
@crenshaw-dev let me know what you think about it: #19508 :) |
As shortly discussed here: #18888
This is the second PR to implement custom resource health for flux resources.
Note: Since I couldn't get some resources to get in the
Progressing
state, I couldn't write proper tests for them:ImagePolicy
ImageRepository
ImageUpdateAutomation
Receiver
Bucket
GitRepository
HelmChart
HelmRepository
OCIRepository
All checks were written based on the documenation of Flux, e.g. https://fluxcd.io/flux/components/kustomize/kustomizations/#conditions
Checklist: