-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add suspended status in custom resource health for flux resources #19508
Conversation
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19508 +/- ##
==========================================
- Coverage 55.84% 55.82% -0.02%
==========================================
Files 315 315
Lines 43654 43654
==========================================
- Hits 24377 24370 -7
- Misses 16722 16724 +2
- Partials 2555 2560 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…es (argoproj#19508) Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com>
…es (argoproj#19508) Signed-off-by: Adrian Berger <adrian.berger@bedag.ch> Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com> Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
As discussed in #19082 I've added an additional custom resource health condition for flux resources.
This condition will check if the resource is in the
suspended
state and set the status (https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-1-define-a-custom-health-check-in-argocd-cm-configmap) accordingly.Checklist: