Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add suspended status in custom resource health for flux resources #19508

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

adberger
Copy link
Contributor

As discussed in #19082 I've added an additional custom resource health condition for flux resources.
This condition will check if the resource is in the suspended state and set the status (https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-1-define-a-custom-health-check-in-argocd-cm-configmap) accordingly.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@adberger adberger requested a review from a team as a code owner August 13, 2024 05:51
Copy link

bunnyshell bot commented Aug 13, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 13, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.82%. Comparing base (539a3e3) to head (ae5df5a).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19508      +/-   ##
==========================================
- Coverage   55.84%   55.82%   -0.02%     
==========================================
  Files         315      315              
  Lines       43654    43654              
==========================================
- Hits        24377    24370       -7     
- Misses      16722    16724       +2     
- Partials     2555     2560       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wanghong230 wanghong230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@todaywasawesome todaywasawesome enabled auto-merge (squash) August 14, 2024 16:10
@todaywasawesome todaywasawesome merged commit 6296b17 into argoproj:master Aug 14, 2024
28 of 29 checks passed
ChichiCaleb pushed a commit to ChichiCaleb/argo-cd that referenced this pull request Aug 15, 2024
…es (argoproj#19508)

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com>
ChichiCaleb pushed a commit to ChichiCaleb/argo-cd that referenced this pull request Aug 15, 2024
…es (argoproj#19508)

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
Signed-off-by: ChichiCaleb <ChichiCaleb@chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants