Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventOverflow console warnings (#7297) #7298

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

reginapizza
Copy link
Contributor

Closes #7297

I saw this error, googled it, and saw this issue in the tippyjs github repo: atomiks/tippyjs#105
I guess you need the hide modified to be included, so I added it everywhere that had popperOptions and the console warnings no longer appear.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Regina Scott <rescott@redhat.com>
@reginapizza reginapizza force-pushed the preventOverflowPopperError branch from d57afcb to 299f3de Compare September 27, 2021 19:08
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #7298 (299f3de) into master (b1f979a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7298   +/-   ##
=======================================
  Coverage   41.10%   41.10%           
=======================================
  Files         160      160           
  Lines       21505    21505           
=======================================
  Hits         8840     8840           
  Misses      11399    11399           
  Partials     1266     1266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f979a...299f3de. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 380037b into argoproj:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preventOverflow console warnings
2 participants