Skip to content

Commit

Permalink
docs(argo-rollouts): add more description for notification secret cre…
Browse files Browse the repository at this point in the history
…ation (#2922)

* docs(argo-rollouts): add more description for secret creation

Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>

* docs(argo-rollouts): bump chart version

Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>

* docs(argo-rollouts): fix lint

Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>

* docs(argo-rollouts): change reference to controller

Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>

* docs(argo-rollouts): fix readme

Signed-off-by: Mykola Stasiuk <93274808+st-myk@users.noreply.github.com>

---------

Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>
Signed-off-by: Mykola Stasiuk <93274808+st-myk@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
  • Loading branch information
st-myk and yu-croco authored Sep 16, 2024
1 parent b33b3db commit 2e05c8b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.7.2
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.37.6
version: 2.37.7
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -18,5 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: add loadBalancerClass field for Service resources
- kind: added
description: add description for manual secret creation
2 changes: 1 addition & 1 deletion charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ For full list of changes please check ArtifactHub [changelog].
| notifications.configmap.create | bool | `true` | Whether to create notifications configmap |
| notifications.notifiers | object | `{}` | Configures notification services |
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
| notifications.secret.create | bool | `false` | Whether to create notifications secret. |
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
| notifications.subscriptions | list | `[]` | The subscriptions define the subscriptions to the triggers in a general way for all rollouts |
| notifications.templates | object | `{}` | Notification templates |
Expand Down
3 changes: 2 additions & 1 deletion charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,8 @@ notifications:
create: true

secret:
# -- Whether to create notifications secret
# -- Whether to create notifications secret.
## If you want to manually create secret, do not forget to add proper label to it: "app.kubernetes.io/component: {{ .Values.controller.component }}".
create: false
# -- Generic key:value pairs to be inserted into the notifications secret
items: {}
Expand Down

0 comments on commit 2e05c8b

Please sign in to comment.