docs(argo-rollouts): add more description for notification secret creation #2922
Conversation
Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>
Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>
Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>
charts/argo-rollouts/values.yaml
Outdated
| @@ -456,7 +456,8 @@ notifications: | |||
| create: true | |||
|
|
|||
| secret: | |||
| # -- Whether to create notifications secret | |||
| # -- Whether to create notifications secret. | |||
| ## If you want to manually create secret, do not forget to add proper label to it: "app.kubernetes.io/component: rollouts-controller". | |||
There was a problem hiding this comment.
Thank you for your PR.
nits; The label in secret is app.kubernetes.io/component: {{ .Values.controller.component }}, so it's not always true that rollouts-controller is the right value. 🤔
Ref: https://github.com/argoproj/argo-helm/blob/argo-rollouts-2.37.6/charts/argo-rollouts/templates/controller/notifications-secret.yaml#L14
There was a problem hiding this comment.
Alright, I will proceed with referencing the {{ .Values.controller.component }} then
There was a problem hiding this comment.
Hi @st-myk
thank you your update. Please run ./scripts/helm-docs.sh to pass CI, as following below, the PR description.
I have updated the documentation according to documentation
There was a problem hiding this comment.
Thank you for your patience 🙂
Signed-off-by: st-myk <93274808+st-myk@users.noreply.github.com>
Signed-off-by: Mykola Stasiuk <93274808+st-myk@users.noreply.github.com>
Checklist: