fix(argo-cd): Ensure app.kubernetes.io/version label is valid

[sathieu]

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

Before:

$ helm template  charts/argo-cd/ | grep /version | head -1
    app.kubernetes.io/version: v2.7.7
$   # ^^^ This one is valid
$ helm template --set global.image.tag=v2.7.5@sha256:d93e1c2fa8c806b339d9288a4de59bff293f2f81e8efbcb charts/argo-cd/ | grep /version | head -1
    app.kubernetes.io/version: v2.7.5@sha256:d93e1c2fa8c806b339d9288a4de59bff293f2f81e8efbcb
$   # ^^^ This one is invalid!

After:

$ helm template  charts/argo-cd/ | grep /version | head -1
    app.kubernetes.io/version: "v2.7.7"
$   # ^^^ This one is valid, and unchanged
$ helm template --set global.image.tag=.v2.7.5@sha256:d93e1c2fa8c806b339d9288a4de59bff293f2f81e8efbcb. charts/argo-cd/ | grep /version | head -1
    app.kubernetes.io/version: "v2.7.5-sha256-d93e1c2fa8c806b339d9288a4de59bff293f2f81e8efbcb"
$   # ^^^ This one is now valid

[mkilchhofer]

I think we need to dicuss it again.
This feature was removed in the past (also by you @sathieu ;-) ):

• fix(argo-cd): Remove version labels to avoid invalid characters #1432

Also related to:

• chore(argo-cd): Add app.kubernetes.io/version label #2122 ( @yu-croco )
• fix(argo-cd): Avoid invalid labels when image tags have digest #1427

[sathieu]

Please review (I've rebased to fix Chart.yaml conflict).

This is a blocker for us.

[mkilchhofer]

Do you think you covered all cases this time? :D
I am also fine in dropping the label completly and revert #2122

[sathieu]

@mkilchhofer Yes. All cases are covered now.

I'm OK to drop the version completely, but #2118 would probably come back later 🧟 !

[sathieu]

thanks for merging so fast 🙏 !