feat(argo-cd): adds toggle for helm-working-dir #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahamilton55
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
|
Can you please update the changelog? |
andrewhamilton-okta
force-pushed
the
ah/allow-helm-working-disable
branch
2 times, most recently
from
c45abf2 to
dcc9681
Compare
|
@tico24 Updated. |
tico24
approved these changes
Sep 5, 2023
pdrastil
reviewed
Sep 5, 2023
charts/argo-cd/values.yaml
Outdated
| @@ -2152,6 +2152,11 @@ repoServer: | |||
| # - name: cmp-tmp | |||
| # emptyDir: {} | |||
|
|
|||
| # -- Toggle the usage of a shared Helm working directory | |||
| helmWorkingDir: | |||
There was a problem hiding this comment.
This is map, not a feature toggle. Are we expecting another set of parameters that will be inside of map or is it just for enabling / disabling the directory? WDYT @mkilchhofer @jmeridth
There was a problem hiding this comment.
I think I originally had this setup as just a single boolean variable but thought it looked cleaner and like other values with and enabled. I also thought that perhaps making the path configurable in the future could be something that people might want so allowing it to expand could be helpful.
I can change the comment or make all of this into a single variable.
There was a problem hiding this comment.
The reason why I'm asking the rest of the team is that we had this historically in chart roughly 1 year ago for multiple features that were a map with single parameter and nothing else. These sections were eventually moved either to simple global toggles in top of the values.yaml or into cm and params sections if possible. Only one that I survived this cleanup is currently openshift.enabled until I can do some regression on OpenShift cluster.
There was a problem hiding this comment.
I think we should use a top-level .Values.useEphemeralHelmWorkingDir (or .Values.helmEmptyDir or similar 😉) bool or move it below the repoServer: structure.
There was a problem hiding this comment.
My vote would be to keep this inside of the repoServer structure since it only corresponds to that service and recreate it as just as a single boolean value. I can update the PR if this is the direction you want to go towards.
There was a problem hiding this comment.
My vote would be to keep this inside of the
repoServerstructure since it only correspo
Sure 👍 the only thing is that we don't preffer a subkey repoServer.bla.enabled if there is only an enabled/disabled option below the bla subkey. Subkey is fine if there are multiple options down there.
There was a problem hiding this comment.
Okay I updated it based on a few of the above comments and turned it into a single boolean under the repoServer section.
- Adds a toggle to be able to turn off the helm-working-dir for the repo server deployment. Using a shared helm repo storage directory can cause issues when multiple helm commands are being run in parallel. The repo server also has the ability to rebuild the repos and do updates in the normal flow for checking the status of an application so it won't cause issues if it's disabled. Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com>
andrewhamilton-okta
force-pushed
the
ah/allow-helm-working-disable
branch
from
dcc9681 to
a4bbb1d
Compare
mkilchhofer
approved these changes
Sep 8, 2023
yu-croco
approved these changes
Sep 9, 2023
yaroslav-codefresh
added a commit
to codefresh-io/argo-helm
that referenced
this pull request
Sep 12, 2023
* feat(argocd-apps): add permitOnlyProjectScopedClusters flag (argoproj#2149) Signed-off-by: Fabián Sellés Rosa <1088313+Fsero@users.noreply.github.com> * feat(argo-cd): Allow configuring Dex's init image resources separately (argoproj#2161) Allow configuring Dex's init image resources separately Signed-off-by: Angelo Ross <angelo.ross@objective.com.br> * chore(deps): bump helm/kind-action from 1.7.0 to 1.8.0 (argoproj#2163) Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@fa81e57...dda0770) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/labeler from 4.2.0 to 4.3.0 (argoproj#2164) Bumps [actions/labeler](https://github.com/actions/labeler) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/actions/labeler/releases) - [Commits](actions/labeler@0967ca8...ac9175f) --- updated-dependencies: - dependency-name: actions/labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(deps): bump actions/setup-python from 4.6.1 to 4.7.0 (argoproj#2165) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@bd6b4b6...61a6322) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-cd): Ensure `app.kubernetes.io/version` label is valid (argoproj#2148) Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr> * feat(argo-cd): allow configurable hpa metrics (argoproj#2166) * allow configurable HPA metrics Signed-off-by: Zach Swanson <zswanson@wayfair.com> * update docs Signed-off-by: Zach Swanson <zswanson@wayfair.com> * Update chart version and changelog Signed-off-by: Zach Swanson <zach.swanson@gmail.com> Signed-off-by: Zach Swanson <zswanson@wayfair.com> * Fix values/readme reference to repo server Signed-off-by: Zach Swanson <zswanson@wayfair.com> --------- Signed-off-by: Zach Swanson <zswanson@wayfair.com> Signed-off-by: Zach Swanson <zach.swanson@gmail.com> Signed-off-by: Zach Swanson <1272954+zswanson@users.noreply.github.com> * feat(argo-cd): make ServiceMonitor deployment conditional on CRD existence (argoproj#2154) * made ServiceMonitor deployment conditional on CRD existence Signed-off-by: alex-souslik-hs <alex.s@hiredscore.com> * remove non ArgoCD changes Signed-off-by: alex-souslik-hs <alex.s@hiredscore.com> * add newline Signed-off-by: Alex Souslik <alex.s@hiredscore.com> * Change chage description Signed-off-by: Alex Souslik <alex.s@hiredscore.com> * Update charts/argo-cd/Chart.yaml Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Signed-off-by: Alex Souslik <alex.s@hiredscore.com> --------- Signed-off-by: alex-souslik-hs <alex.s@hiredscore.com> Signed-off-by: Alex Souslik <alex.s@hiredscore.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> * feat(argo-cd): Upgrade argocd to v2.7.8 (argoproj#2173) Signed-off-by: smcavallo <smcavallo@hotmail.com> * feat(argo-rollouts): Upgrade Argo Rollouts to v1.5.1 (argoproj#2174) * chore(argo-workflows): Upgrade to 3.4.9 (argoproj#2175) chore(argo-workflow): Upgrade to 3.4.9 - [ ] update CRD changes Signed-off-by: jmeridth <jmeridth@gmail.com> * feat(argocd-apps): syncOptions for applications (argoproj#2176) Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argocd-apps): fix indent of syncOptions (argoproj#2181) * chore(github): use table for Emeritus (argoproj#2182) - to matches how `argoproj` lists Alumni (https://github.com/argoproj/argoproj/blob/6011d3e17300d4b642a1ab5bdb3551c5f6da9021/MAINTAINERS.md?plain=1#L11) - though it has more details including role and affiliation. could do that here too, but I don't know what all those are, so left those columns out - fortunately everyone's name was listed on their profile, so just copy+paste those! - confirmed that all links work Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * fix(argo-rollouts): Use annotation cont metrics (argoproj#2184) * fix(argo-rollouts): Use annotation cont metrics Signed-off-by: Artur Mudrykh <a.mudrykh@uzum.com> * fix(argo-rollouts): add changes and bump version Signed-off-by: Artur Mudrykh <a.mudrykh@uzum.com> * fix chart.yaml Signed-off-by: Artur Mudrykh <a.mudrykh@uzum.com> --------- Signed-off-by: Artur Mudrykh <a.mudrykh@uzum.com> Co-authored-by: Artur Mudrykh <a.mudrykh@uzum.com> * chore(argo-cd): Upgrade Argo CD to v2.7.9 (argoproj#2186) feat(argo-cd): Upgrade argocd to v2.7.9 Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com> * feat(argo-workflows): allow setting executor args (argoproj#2177) * feat(argo-cd): add labels to notifications secret (argoproj#2191) (argoproj#2192) Signed-off-by: carlos gonzález <cgrs@users.noreply.github.com> * chore(argo-cd): Upgrade Argo CD to v2.7.10 (argoproj#2197) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-rollouts): fix helm lint error when extraObjects is defined (argoproj#2196) fix(extra-manifests): fix helm lint error when extraObjecrts is defined Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * fix(argo-cd): Template configuration keys as a string instead of map (argoproj#2205) * fix(argo-rollouts): Add required ingress permission (argoproj#2207) * chore(argo-cd): Upgrade Argo CD to v2.7.11 (argoproj#2210) Signed-off-by: yu-croco <yu.croco@gmail.com> * feat(github): add Helm OCI support (argoproj#2209) Signed-off-by: Engin Diri <engin.diri@ediri.de> * feat(argo-cd): Upgrade Argo CD to 2.8.0 (argoproj#2170) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-rollouts): add CI for enabling extra objects for argo-rollouts (argoproj#2198) * fix(argo-rollouts): add CI for enabling extra objects for argo-rollouts Add CI for extra objects Signed-off-by: jmeridth <jmeridth@gmail.com> * fix: rename extra objects ci file to have -values suffix Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-cd): Fix global log level configuration (argoproj#2213) fix(argo-cd) - Fix global log level configuration Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-cd): Change applicationSet replicaCount to replicas (argoproj#2214) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * fix(argo-cd): add missing permissions to run actions (argoproj#2212) Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> * fix(argo-workflows): Server only needs `get` Secrets (argoproj#2211) - as of argoproj/argo-workflows@aa366db, the Server no longer needs `list` or `watch` and only uses `get` - this was released as part of [v3.4.0](https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v340-rc1-2022-08-09), and the current version of the chart uses v3.4.9 (per `Chart.yaml#appVersion`) - `update` is not needed either for SSO secret - manifests RBAC: https://github.com/argoproj/argo-workflows/blob/a68ea0feabc87c09d5e13d12e6f0d1a61adc5b16/manifests/cluster-install/argo-server-rbac/argo-server-clusterole.yaml#L18 - SSO source code only uses [`create`](https://github.com/argoproj/argo-workflows/blob/20d0923611f1df6b7147c3547aeeff6b6bfecf18/server/auth/sso/sso.go#L140) and [`get`](https://github.com/argoproj/argo-workflows/blob/20d0923611f1df6b7147c3547aeeff6b6bfecf18/server/auth/sso/sso.go#L151) - (also some `get`s above that for [`clientID`](https://github.com/argoproj/argo-workflows/blob/20d0923611f1df6b7147c3547aeeff6b6bfecf18/server/auth/sso/sso.go#L127) and [`clientSecret`](https://github.com/argoproj/argo-workflows/blob/20d0923611f1df6b7147c3547aeeff6b6bfecf18/server/auth/sso/sso.go#L106) as well) Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * docs(argo-cd): Rename comment of repositoryCredentials to credentialTemplates (argoproj#2219) Rename comment of repositoryCredentials to credentialTemplates Signed-off-by: Ali Reza <alirezayahya@gmail.com> * feat(argo-rollouts): update servicemonitor.yaml to allow for namespace to be set (argoproj#2222) * Update servicemonitor.yaml to allow for namespace to be set Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * Update README.md Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * Update values.yaml Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * Alphabetized namespace addition in README Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> --------- Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> * chore(argo-workflows): Upgrade to Argo Workflows v3.4.10 (argoproj#2220) * feat(argo-workflows): add imagePullSecret for workflow sa (argoproj#2226) Signed-off-by: Fuochi <ffuochi@hotmail.com> * chore(argo-workflows): update comment for azure artifact repository blobNameFormat (argoproj#2229) * chore(argo-cd): Upgrade Argo CD to v2.8.1 (argoproj#2230) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.2 (argoproj#2231) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Fix applicationSet HA examples in README.md (argoproj#2232) Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> * chore(deps): bump actions/checkout from 3.5.3 to 3.6.0 (argoproj#2234) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(argo-cd): Upgrade redis-exporter to 1.53.0 (argoproj#2236) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-cd): Remove support for legacy cert-manager APIs (argoproj#2238) * chore(argo-cd): Remove support for legacy cert-manager APIs Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * Bump minor version Signed-off-by: Petr Drastil <petr.drastil@gmail.com> --------- Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-cd): Remove support for autoscaling/v1 (argoproj#2237) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-events): Upgrade argo-events to 1.8.1 (argoproj#2247) https://github.com/argoproj/argo-events/releases/tag/v1.8.1 Signed-off-by: jmeridth <jmeridth@gmail.com> * fix(argo-cd): Update values.yaml - update custom css styles side bar example (argoproj#2245) * Update values.yaml - update custom css styles side barexample .nav-bar is no longer the css class name Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update patch version for values.yaml comment update Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update change log Signed-off-by: JesseBot <jessebot@linux.com> --------- Signed-off-by: JesseBot <jessebot@linux.com> * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 (argoproj#2252) * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * chore(argo-rollouts): Update CRDs to matching version Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> --------- Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * fix(argo-cd): Make the PathType configurable when using single ingress resource in AWS (argoproj#2251) * Make the PathType configurable when using single ingress resource in AWS Signed-off-by: Tamas <tamas@ujet.cx> * update chart version and doc Signed-off-by: Tamas <tamas@ujet.cx> * Fix reference to value in range Signed-off-by: Tamas <tamas@ujet.cx> --------- Signed-off-by: Tamas <tamas@ujet.cx> Co-authored-by: Tamas <tamas@ujet.cx> * chore(argo-cd): Upgrade Argo CD to v2.8.3 (argoproj#2254) Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> * chore(argo-workflows): Upgrade Argo Workflows to v3.4.11 (argoproj#2255) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM (argoproj#2235) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Aligne condition to argocd-cm Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): Document scheduling parameters for redis-ha (argoproj#2253) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): adds toggle for helm-working-dir (argoproj#2249) - Adds a toggle to be able to turn off the helm-working-dir for the repo server deployment. Using a shared helm repo storage directory can cause issues when multiple helm commands are being run in parallel. The repo server also has the ability to rebuild the repos and do updates in the normal flow for checking the status of an application so it won't cause issues if it's disabled. Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> * chore(deps): bump actions/checkout from 3.6.0 to 4.0.0 (argoproj#2258) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (argoproj#2259) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * docs(argo-workflows): add an HA section (argoproj#2183) * feat(argo-workflows): add a sample HA config - a `values-ha.yaml` as an example for how one would set-up HA according to the Argo Workflows docs Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * docs(argo-workflows): add an HA section - plus add a test for HA, which the docs link to as an example - link back to [upstream docs](https://argoproj.github.io/argo-workflows/high-availability/) as well - follow the same basic structure as the [Argo CD chart for HA](https://github.com/argoproj/argo-helm/blob/3e35b0c7f7d758d553b17f369cc5940484ef5d89/charts/argo-cd/README.md?plain=1#L17) - as asked in review Signed-off-by: Anton Gilgur <agilgur5@gmail.com> --------- Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-cd): Migrate leftover of applicationSet.replicaCount to applicationSet.replicas (argoproj#2261) Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): improve changelog (argoproj#2262) * clarify 5.19.0 changes * revise wording Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Fabián Sellés Rosa <1088313+Fsero@users.noreply.github.com> Signed-off-by: Angelo Ross <angelo.ross@objective.com.br> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr> Signed-off-by: Zach Swanson <zswanson@wayfair.com> Signed-off-by: Zach Swanson <zach.swanson@gmail.com> Signed-off-by: Zach Swanson <1272954+zswanson@users.noreply.github.com> Signed-off-by: alex-souslik-hs <alex.s@hiredscore.com> Signed-off-by: Alex Souslik <alex.s@hiredscore.com> Signed-off-by: smcavallo <smcavallo@hotmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Artur Mudrykh <a.mudrykh@uzum.com> Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com> Signed-off-by: carlos gonzález <cgrs@users.noreply.github.com> Signed-off-by: yu-croco <yu.croco@gmail.com> Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com> Signed-off-by: Engin Diri <engin.diri@ediri.de> Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com> Signed-off-by: Ali Reza <alirezayahya@gmail.com> Signed-off-by: Nick Kampe <Kampe@users.noreply.github.com> Signed-off-by: Fuochi <ffuochi@hotmail.com> Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Signed-off-by: Tamas <tamas@ujet.cx> Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Fabián Sellés Rosa <1088313+Fsero@users.noreply.github.com> Co-authored-by: Angelo Ross <angeloborsoiross@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> Co-authored-by: Mathieu Parent <mathieu.parent@insee.fr> Co-authored-by: Zach Swanson <1272954+zswanson@users.noreply.github.com> Co-authored-by: Alex Souslik <alex.s@hiredscore.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: smcavallo <smcavallo@users.noreply.github.com> Co-authored-by: Takuma Kume <takuma.kume@gmail.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Artur <arturmon82@gmail.com> Co-authored-by: Artur Mudrykh <a.mudrykh@uzum.com> Co-authored-by: Venkata Mutyala <venkata@venkatamutyala.com> Co-authored-by: Andy Cobaugh <andrew.cobaugh@gmail.com> Co-authored-by: carlos gonzález <cgrs@users.noreply.github.com> Co-authored-by: Grégory SANCHEZ <gregory.sanchez@icloud.com> Co-authored-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: Engin Diri <engin.diri@ediri.de> Co-authored-by: Mickaël Canévet <mickael.canevet@gmail.com> Co-authored-by: Ali Reza <alirezayahya@gmail.com> Co-authored-by: Nick Kampe <Kampe@users.noreply.github.com> Co-authored-by: Fuochi <ffuochi@hotmail.com> Co-authored-by: Jeongwon Song <46633758+jsong336@users.noreply.github.com> Co-authored-by: Joonas Venäläinen <38143731+joonvena@users.noreply.github.com> Co-authored-by: JesseBot <jessebot@linux.com> Co-authored-by: Gustav Kofoed Clausen <gustav@gustavclausen.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Tamas Szasz <szasz.tamas@gmail.com> Co-authored-by: Tamas <tamas@ujet.cx> Co-authored-by: Alexej Disterhoft <github@disterhoft.de> Co-authored-by: Andrew Hamilton <ahamilton55@gmail.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
yaroslav-codefresh
added a commit
to codefresh-io/argo-helm
that referenced
this pull request
Dec 7, 2023
* chore(argo-workflows): Upgrade to Argo Workflows v3.4.10 (argoproj#2220) * feat(argo-workflows): add imagePullSecret for workflow sa (argoproj#2226) Signed-off-by: Fuochi <ffuochi@hotmail.com> * chore(argo-workflows): update comment for azure artifact repository blobNameFormat (argoproj#2229) * chore(argo-cd): Upgrade Argo CD to v2.8.1 (argoproj#2230) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.2 (argoproj#2231) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Fix applicationSet HA examples in README.md (argoproj#2232) Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> * chore(deps): bump actions/checkout from 3.5.3 to 3.6.0 (argoproj#2234) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(argo-cd): Upgrade redis-exporter to 1.53.0 (argoproj#2236) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-cd): Remove support for legacy cert-manager APIs (argoproj#2238) * chore(argo-cd): Remove support for legacy cert-manager APIs Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * Bump minor version Signed-off-by: Petr Drastil <petr.drastil@gmail.com> --------- Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-cd): Remove support for autoscaling/v1 (argoproj#2237) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-events): Upgrade argo-events to 1.8.1 (argoproj#2247) https://github.com/argoproj/argo-events/releases/tag/v1.8.1 Signed-off-by: jmeridth <jmeridth@gmail.com> * fix(argo-cd): Update values.yaml - update custom css styles side bar example (argoproj#2245) * Update values.yaml - update custom css styles side barexample .nav-bar is no longer the css class name Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update patch version for values.yaml comment update Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update change log Signed-off-by: JesseBot <jessebot@linux.com> --------- Signed-off-by: JesseBot <jessebot@linux.com> * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 (argoproj#2252) * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * chore(argo-rollouts): Update CRDs to matching version Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> --------- Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * fix(argo-cd): Make the PathType configurable when using single ingress resource in AWS (argoproj#2251) * Make the PathType configurable when using single ingress resource in AWS Signed-off-by: Tamas <tamas@ujet.cx> * update chart version and doc Signed-off-by: Tamas <tamas@ujet.cx> * Fix reference to value in range Signed-off-by: Tamas <tamas@ujet.cx> --------- Signed-off-by: Tamas <tamas@ujet.cx> Co-authored-by: Tamas <tamas@ujet.cx> * chore(argo-cd): Upgrade Argo CD to v2.8.3 (argoproj#2254) Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> * chore(argo-workflows): Upgrade Argo Workflows to v3.4.11 (argoproj#2255) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM (argoproj#2235) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Aligne condition to argocd-cm Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): Document scheduling parameters for redis-ha (argoproj#2253) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): adds toggle for helm-working-dir (argoproj#2249) - Adds a toggle to be able to turn off the helm-working-dir for the repo server deployment. Using a shared helm repo storage directory can cause issues when multiple helm commands are being run in parallel. The repo server also has the ability to rebuild the repos and do updates in the normal flow for checking the status of an application so it won't cause issues if it's disabled. Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> * chore(deps): bump actions/checkout from 3.6.0 to 4.0.0 (argoproj#2258) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (argoproj#2259) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * docs(argo-workflows): add an HA section (argoproj#2183) * feat(argo-workflows): add a sample HA config - a `values-ha.yaml` as an example for how one would set-up HA according to the Argo Workflows docs Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * docs(argo-workflows): add an HA section - plus add a test for HA, which the docs link to as an example - link back to [upstream docs](https://argoproj.github.io/argo-workflows/high-availability/) as well - follow the same basic structure as the [Argo CD chart for HA](https://github.com/argoproj/argo-helm/blob/3e35b0c7f7d758d553b17f369cc5940484ef5d89/charts/argo-cd/README.md?plain=1#L17) - as asked in review Signed-off-by: Anton Gilgur <agilgur5@gmail.com> --------- Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-cd): Migrate leftover of applicationSet.replicaCount to applicationSet.replicas (argoproj#2261) Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): improve changelog (argoproj#2262) * clarify 5.19.0 changes * revise wording Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * fix(github): Fix changelog spelling of versions (argoproj#2263) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.4 (argoproj#2268) * fix(argo-cd): Align redis-ha's affinity type to upstream due to warnings (argoproj#2270) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(deps): bump docker/login-action from 2.2.0 to 3.0.0 (argoproj#2271) * fix(argo-cd): make ServiceMonitor annotations in ArgoCD server conditional (argoproj#2273) * fix: add argocd servicemonitor annotations conditionally Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> * chore(argo-cd): add changelog Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> --------- Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> * fix(argo-cd): Add checksum for CMP ConfigMap in repo-server Pod annotations (argoproj#2275) Add checksum for CMP ConfigMap in repo-server This helm chart defines the plugins as ConfigMaps -- according to the docs, when the CM is modified, the repo-server Pod must be restarted to have the sidecars pick up the latest changes: https://argo-cd.readthedocs.io/en/stable/operator-manual/config-management-plugins/#debugging-a-cmp The changes in this helm chart allow for a checksum to be calculated from the ConfigMap and added as a Pod annotation so whenever the CM values are modified, the Pod is restarted automatically. Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com> * fix(argo-cd): Redis to 7.0.13 to fix CVE-2022-48174 (argoproj#2279) * Redis to 7.0.13 Signed-off-by: Pieter van der Giessen <pieter@pionative.com> * changelog Signed-off-by: Pieter van der Giessen <pieter@pionative.com> --------- Signed-off-by: Pieter van der Giessen <pieter@pionative.com> * chore(deps): bump actions/checkout from 4.0.0 to 4.1.0 (argoproj#2280) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump amannn/action-semantic-pull-request from 5.2.0 to 5.3.0 (argoproj#2284) * chore(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (argoproj#2290) * chore(deps): bump actions/setup-python from 4.7.0 to 4.7.1 (argoproj#2289) * fix(argo-cd): Sync redis / redis-ha readOnlyRootFilesystem from upstream (argoproj#2294) Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> * feat(argo-workflows): Configure declarative server auth mode (argoproj#2291) * chore(argo-workflows): Upgrade argo-workflows to 3.5.0 (argoproj#2228) Diff based on the rc1 branch currently here [3.4.10...3.5.0](argoproj/argo-workflows@v3.4.10...v3.5.0) Signed-off-by: jmeridth <jmeridth@gmail.com> * feat(argo-workflows): Added commonLabels (argoproj#2300) * fix(argo-workflows): add all crds to aggregate-roles template (argoproj#2301) fix: add all crds to aggregate-roles Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com> * chore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (argoproj#2304) * chore(argo-workflows): Add sample of PostgreSQL ssl entries in values.yaml (argoproj#2307) Signed-off-by: yu-croco <yu.croco@gmail.com> * feat(argo-workflows): Updated supported workers parameters (argoproj#2297) * feat(argo-workflows): Updated supported workers parameters Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> * Addressing PR feedback. Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> * newline Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> --------- Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> Co-authored-by: Evgeny Khatko <ekhatko@paypal.com> Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com> * fix(argo-rollouts): controller replicas count comparison (argoproj#2309) * feat(argo-cd): add terminationGracePeriodSeconds (argoproj#2310) Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.5 (argoproj#2313) * chore(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (argoproj#2314) * fix(argo-cd): Update Bitbucket SSH key (argoproj#2317) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): add notification cluster role (argoproj#2315) * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * fix(argo-rollouts): Update AnalysisRun CRD to match upstream (argoproj#2320) * fix(github): update chart testing action due to failure (argoproj#2324) Getting failure when running chart testing action pulling v2.0.0 from sigstore Updating action to see if this helps Signed-off-by: jmeridth <jmeridth@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.6 (argoproj#2323) * chore(argo-cd): Upgrade Argo CD to v2.8.6 Signed-off-by: Tim Collins <tim@thecollins.team> * fix: drop unrecognized helm timeout Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: Tim Collins <tim@thecollins.team> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * fix(argo-cd): Create notifications clusterrole and clusterrolebinding when enabled (argoproj#2326) * Create clusterrole for nitifications only when notifications enabled Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Create clusterrolebinding for nitifications only when notifications enbaled Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Bump version in Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Update Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Update Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> --------- Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * fix(argo-workflows): Fix outdated URL in values.yaml comments (argoproj#2328) * fix outdated link branch link Branch was renamed prior, redirects to main now Signed-off-by: Max! <admin@cloudydev.net> * Update Chart.yaml Signed-off-by: Max! <admin@cloudydev.net> * add to changelog Signed-off-by: Max! <admin@cloudydev.net> --------- Signed-off-by: Max! <admin@cloudydev.net> * chore(argo-workflows): Upgrade Argo Workflows to v3.5.1 (argoproj#2329) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (argoproj#2330) chore(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@47b15d5...e9fabac) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (argoproj#2331) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@be16258...a917fd1) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1 (argoproj#2332) Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/helm/chart-testing-action/releases) - [Commits](helm/chart-testing-action@b43128a...e6669bc) --- updated-dependencies: - dependency-name: helm/chart-testing-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(argo-cd): Upgrade Argo CD to 2.9.0 (argoproj#2318) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(github): Updated security documentation and CLOMonitor exemptions (argoproj#2333) * Updated security documentation and CLOMonitor exemptions Signed-off-by: Eddie Knight <knight@linux.com> * Added license scanning exepmtion Signed-off-by: Eddie Knight <knight@linux.com> * Added best practices badge to README Signed-off-by: Eddie Knight <knight@linux.com> --------- Signed-off-by: Eddie Knight <knight@linux.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * fix(argo-workflows): Accept multi auth mode for server (argoproj#2336) * fix(argo-workflows): Accept multi auth mode for server Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): improve description of authMode Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): keep the older value valid for now as compatibility. Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(github): Add yu-cruco to * in CODEOWNERS (argoproj#2338) chore: Add yu-cruco to * in CODEOWNERS yu-cruco is now a maintainer and will be notified on all PRs - [x] moved CODEOWNERS into .github folder where it belongs Signed-off-by: jmeridth <jmeridth@gmail.com> * fix(argo-cd): Add permission for Applications in any namespace (argoproj#2341) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.9.1 (argoproj#2344) * chore(argo-rollouts): Bump rollouts to 1.6.1 (argoproj#2345) * Bump rollouts to 1.6.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump to 1.6.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump to 1.6.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-rollouts): Bump rollouts to 1.6.2 (argoproj#2347) * fix(argo-workflows): Add parameters for tuning revisionHistoryLimit and emptyDir volumes (argoproj#2346) * fix(argo-workflows): Align version label (argoproj#2342) * fix(argo-workflows): Aligne version label Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-workflows): fix typo Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(github): typo fix in security.md (argoproj#2343) * typo fix Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> * Revert "typo fix" This reverts commit b02b2fb. Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> * typo fix in SECURITY.md Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> --------- Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-workflows): Remove xip url from test to avoid confusion (argoproj#2350) * chore(argo-workflows): Remove xip url from test to avoid confusion Signed-off-by: Tim Collins <tim@thecollins.team> * Bump version Signed-off-by: Tim Collins <tim@thecollins.team> * More bumpings Signed-off-by: Tim Collins <tim@thecollins.team> * Tim can't type Signed-off-by: Tim Collins <tim@thecollins.team> * Swap to example.com - rfc2606 Signed-off-by: Tim Collins <tim@thecollins.team> --------- Signed-off-by: Tim Collins <tim@thecollins.team> * chore(argo-cd): Replace non-existing examples with official example domain (argoproj#2352) * chore(argo-cd): Upgrade Argo CD to v2.9.2 (argoproj#2353) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(github): Update SECURITY-INSIGHTS.yml to include security-contacts (argoproj#2356) * feat(argo-workflows): Make workflow controller ConfigMap optional (argoproj#2354) * chore(argo-workflows): Upgrade Argo Workflows to v3.5.2 (argoproj#2357) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-rollouts): Update all rollout CRDs to match upstream (argoproj#2361) Signed-off-by: Abdulla Abdurakhmanov <me@abdolence.dev> * change image tag * change image tag --------- Signed-off-by: Fuochi <ffuochi@hotmail.com> Signed-off-by: yu-croco <yu.croco@gmail.com> Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Signed-off-by: Tamas <tamas@ujet.cx> Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com> Signed-off-by: Pieter van der Giessen <pieter@pionative.com> Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com> Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Tim Collins <tim@thecollins.team> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Signed-off-by: Denis Kadyshev <metajiji@gmail.com> Signed-off-by: Max! <admin@cloudydev.net> Signed-off-by: Eddie Knight <knight@linux.com> Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Signed-off-by: Abdulla Abdurakhmanov <me@abdolence.dev> Co-authored-by: Jason Meridth <jmeridth@gmail.com> Co-authored-by: Fuochi <ffuochi@hotmail.com> Co-authored-by: Jeongwon Song <46633758+jsong336@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> Co-authored-by: Joonas Venäläinen <38143731+joonvena@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: JesseBot <jessebot@linux.com> Co-authored-by: Gustav Kofoed Clausen <gustav@gustavclausen.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Tamas Szasz <szasz.tamas@gmail.com> Co-authored-by: Tamas <tamas@ujet.cx> Co-authored-by: Alexej Disterhoft <github@disterhoft.de> Co-authored-by: Andrew Hamilton <ahamilton55@gmail.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Mats Willemsen <60099717+ma-ts@users.noreply.github.com> Co-authored-by: sibucan <luis.ramirez.rivera92@gmail.com> Co-authored-by: Pieter <110168856+Pionerd@users.noreply.github.com> Co-authored-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com> Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com> Co-authored-by: Jonathan Raymond <jonwraymond@gmail.com> Co-authored-by: Ujin <592652+evgeniy-khatko@users.noreply.github.com> Co-authored-by: Evgeny Khatko <ekhatko@paypal.com> Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com> Co-authored-by: gussan <83329336+toyamagu-2021@users.noreply.github.com> Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: Denis Kadyshev <metajiji@gmail.com> Co-authored-by: Max! <admin@cloudydev.net> Co-authored-by: Eddie Knight <knight@linux.com> Co-authored-by: Matt Dainty <matt@bodgit-n-scarper.com> Co-authored-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Co-authored-by: qa-florian-wende <113123884+qa-florian-wende@users.noreply.github.com> Co-authored-by: Abdulla Abdurakhmanov <me@abdolence.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having issues with collisions happening in the shared helm-working-dir and with the index.yaml file being empty when read by one of the processes. The repo server code is setup to rebuild the repo and do a chart build for each templating run for us so it makes more sense to allow it to utilize the temporary space. I didn't want to remove it for everyone so I made the default to enabled with the option to disable it. Since testing this change in one of our environments we've had no issues with services consistently entering the Unknown state.
Checklist: