fix(argo-workflows): Accept multi auth mode for server #2336

yu-croco · 2023-11-08T06:29:10Z

Auth mode is supposed to accept multi values, so I fixed it.
Ref: #2291 (comment)

Checklist:

I have bumped the chart version according to versioning
I have updated the documentation according to documentation
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Any new values are backwards compatible and/or have sensible default.
I have signed off all my commits as required by DCO.
My build is green (troubleshooting builds).

Signed-off-by: yu-croco <yu.croco@gmail.com>

yu-croco · 2023-11-08T06:29:41Z

charts/argo-workflows/templates/server/server-deployment.yaml

-          {{- if .Values.server.authMode }}
-          - "--auth-mode={{ .Values.server.authMode }}"
+          {{- range .Values.server.authMode }}
+          - "--auth-mode={{ . }}"


📝
ref: https://argoproj.github.io/argo-workflows/argo-server-auth-mode/

vladlosev · 2023-11-08T09:08:28Z

charts/argo-workflows/README.md

@@ -260,7 +260,7 @@ Fields to note:
 | server.GKEmanagedCertificate.domains | list | `["argoworkflows.example.com"]` | Domains for the Google Managed Certificate |
 | server.GKEmanagedCertificate.enabled | bool | `false` | Enable ManagedCertificate custom resource for Google Kubernetes Engine. |
 | server.affinity | object | `{}` | Assign custom [affinity] rules |
-| server.authMode | string | `""` | Auth Mode is available from `server` , `client` or `sso`. If you chose `sso` , please configure `.Values.server.sso` as well. |
+| server.authMode | list | `[]` | Auth Mode is available from `server` , `client` or `sso`. If you chose `sso` , please configure `.Values.server.sso` as well. |


Maybe change it to A list of supported authentication modes. Available values are server, client, or sso. If you provide sso, please configure .Values.server.sso as well.. That makes it clearer that multiple values can be used.

Thank you for your review. I fixed in 3366c7c 🙋

Signed-off-by: yu-croco <yu.croco@gmail.com>

jmeridth · 2023-11-08T12:17:15Z

charts/argo-workflows/values.yaml

  ## Ref: https://argoproj.github.io/argo-workflows/argo-server-auth-mode/
-  authMode: ""
+  authMode: []


Great change. Thank you.

Could this break existing users who have it set to a string? Should we add something in NOTES.txt about a deprecation and handle both for a bit? I don't know if it is worth it. wdyt? 🤔

Thank you for your review.
That's right, it's kind. I fixed it in f5aa459 😄

…ility. Signed-off-by: yu-croco <yu.croco@gmail.com>

vladlosev

LGTM

* fix(argo-workflows): Accept multi auth mode for server Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): improve description of authMode Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): keep the older value valid for now as compatibility. Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>

* chore(argo-workflows): Upgrade to Argo Workflows v3.4.10 (argoproj#2220) * feat(argo-workflows): add imagePullSecret for workflow sa (argoproj#2226) Signed-off-by: Fuochi <ffuochi@hotmail.com> * chore(argo-workflows): update comment for azure artifact repository blobNameFormat (argoproj#2229) * chore(argo-cd): Upgrade Argo CD to v2.8.1 (argoproj#2230) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.2 (argoproj#2231) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Fix applicationSet HA examples in README.md (argoproj#2232) Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> * chore(deps): bump actions/checkout from 3.5.3 to 3.6.0 (argoproj#2234) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(argo-cd): Upgrade redis-exporter to 1.53.0 (argoproj#2236) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-cd): Remove support for legacy cert-manager APIs (argoproj#2238) * chore(argo-cd): Remove support for legacy cert-manager APIs Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * Bump minor version Signed-off-by: Petr Drastil <petr.drastil@gmail.com> --------- Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-cd): Remove support for autoscaling/v1 (argoproj#2237) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(argo-events): Upgrade argo-events to 1.8.1 (argoproj#2247) https://github.com/argoproj/argo-events/releases/tag/v1.8.1 Signed-off-by: jmeridth <jmeridth@gmail.com> * fix(argo-cd): Update values.yaml - update custom css styles side bar example (argoproj#2245) * Update values.yaml - update custom css styles side barexample .nav-bar is no longer the css class name Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update patch version for values.yaml comment update Signed-off-by: JesseBot <jessebot@linux.com> * Update Chart.yaml - update change log Signed-off-by: JesseBot <jessebot@linux.com> --------- Signed-off-by: JesseBot <jessebot@linux.com> * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 (argoproj#2252) * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * chore(argo-rollouts): Update CRDs to matching version Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> --------- Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> * fix(argo-cd): Make the PathType configurable when using single ingress resource in AWS (argoproj#2251) * Make the PathType configurable when using single ingress resource in AWS Signed-off-by: Tamas <tamas@ujet.cx> * update chart version and doc Signed-off-by: Tamas <tamas@ujet.cx> * Fix reference to value in range Signed-off-by: Tamas <tamas@ujet.cx> --------- Signed-off-by: Tamas <tamas@ujet.cx> Co-authored-by: Tamas <tamas@ujet.cx> * chore(argo-cd): Upgrade Argo CD to v2.8.3 (argoproj#2254) Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> * chore(argo-workflows): Upgrade Argo Workflows to v3.4.11 (argoproj#2255) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM (argoproj#2235) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-cd): Aligne condition to argocd-cm Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): Document scheduling parameters for redis-ha (argoproj#2253) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): adds toggle for helm-working-dir (argoproj#2249) - Adds a toggle to be able to turn off the helm-working-dir for the repo server deployment. Using a shared helm repo storage directory can cause issues when multiple helm commands are being run in parallel. The repo server also has the ability to rebuild the repos and do updates in the normal flow for checking the status of an application so it won't cause issues if it's disabled. Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> * chore(deps): bump actions/checkout from 3.6.0 to 4.0.0 (argoproj#2258) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (argoproj#2259) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * docs(argo-workflows): add an HA section (argoproj#2183) * feat(argo-workflows): add a sample HA config - a `values-ha.yaml` as an example for how one would set-up HA according to the Argo Workflows docs Signed-off-by: Anton Gilgur <agilgur5@gmail.com> * docs(argo-workflows): add an HA section - plus add a test for HA, which the docs link to as an example - link back to [upstream docs](https://argoproj.github.io/argo-workflows/high-availability/) as well - follow the same basic structure as the [Argo CD chart for HA](https://github.com/argoproj/argo-helm/blob/3e35b0c7f7d758d553b17f369cc5940484ef5d89/charts/argo-cd/README.md?plain=1#L17) - as asked in review Signed-off-by: Anton Gilgur <agilgur5@gmail.com> --------- Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * fix(argo-cd): Migrate leftover of applicationSet.replicaCount to applicationSet.replicas (argoproj#2261) Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(argo-cd): improve changelog (argoproj#2262) * clarify 5.19.0 changes * revise wording Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * fix(github): Fix changelog spelling of versions (argoproj#2263) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.4 (argoproj#2268) * fix(argo-cd): Align redis-ha's affinity type to upstream due to warnings (argoproj#2270) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(deps): bump docker/login-action from 2.2.0 to 3.0.0 (argoproj#2271) * fix(argo-cd): make ServiceMonitor annotations in ArgoCD server conditional (argoproj#2273) * fix: add argocd servicemonitor annotations conditionally Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> * chore(argo-cd): add changelog Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> --------- Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> * fix(argo-cd): Add checksum for CMP ConfigMap in repo-server Pod annotations (argoproj#2275) Add checksum for CMP ConfigMap in repo-server This helm chart defines the plugins as ConfigMaps -- according to the docs, when the CM is modified, the repo-server Pod must be restarted to have the sidecars pick up the latest changes: https://argo-cd.readthedocs.io/en/stable/operator-manual/config-management-plugins/#debugging-a-cmp The changes in this helm chart allow for a checksum to be calculated from the ConfigMap and added as a Pod annotation so whenever the CM values are modified, the Pod is restarted automatically. Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com> * fix(argo-cd): Redis to 7.0.13 to fix CVE-2022-48174 (argoproj#2279) * Redis to 7.0.13 Signed-off-by: Pieter van der Giessen <pieter@pionative.com> * changelog Signed-off-by: Pieter van der Giessen <pieter@pionative.com> --------- Signed-off-by: Pieter van der Giessen <pieter@pionative.com> * chore(deps): bump actions/checkout from 4.0.0 to 4.1.0 (argoproj#2280) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump amannn/action-semantic-pull-request from 5.2.0 to 5.3.0 (argoproj#2284) * chore(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (argoproj#2290) * chore(deps): bump actions/setup-python from 4.7.0 to 4.7.1 (argoproj#2289) * fix(argo-cd): Sync redis / redis-ha readOnlyRootFilesystem from upstream (argoproj#2294) Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> * feat(argo-workflows): Configure declarative server auth mode (argoproj#2291) * chore(argo-workflows): Upgrade argo-workflows to 3.5.0 (argoproj#2228) Diff based on the rc1 branch currently here [3.4.10...3.5.0](argoproj/argo-workflows@v3.4.10...v3.5.0) Signed-off-by: jmeridth <jmeridth@gmail.com> * feat(argo-workflows): Added commonLabels (argoproj#2300) * fix(argo-workflows): add all crds to aggregate-roles template (argoproj#2301) fix: add all crds to aggregate-roles Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com> * chore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (argoproj#2304) * chore(argo-workflows): Add sample of PostgreSQL ssl entries in values.yaml (argoproj#2307) Signed-off-by: yu-croco <yu.croco@gmail.com> * feat(argo-workflows): Updated supported workers parameters (argoproj#2297) * feat(argo-workflows): Updated supported workers parameters Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> * Addressing PR feedback. Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> * newline Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> * Update Chart.yaml Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> --------- Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> Co-authored-by: Evgeny Khatko <ekhatko@paypal.com> Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com> * fix(argo-rollouts): controller replicas count comparison (argoproj#2309) * feat(argo-cd): add terminationGracePeriodSeconds (argoproj#2310) Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.5 (argoproj#2313) * chore(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (argoproj#2314) * fix(argo-cd): Update Bitbucket SSH key (argoproj#2317) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): add notification cluster role (argoproj#2315) * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Add notification cluster role Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * fix(argo-rollouts): Update AnalysisRun CRD to match upstream (argoproj#2320) * fix(github): update chart testing action due to failure (argoproj#2324) Getting failure when running chart testing action pulling v2.0.0 from sigstore Updating action to see if this helps Signed-off-by: jmeridth <jmeridth@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.8.6 (argoproj#2323) * chore(argo-cd): Upgrade Argo CD to v2.8.6 Signed-off-by: Tim Collins <tim@thecollins.team> * fix: drop unrecognized helm timeout Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: Tim Collins <tim@thecollins.team> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * fix(argo-cd): Create notifications clusterrole and clusterrolebinding when enabled (argoproj#2326) * Create clusterrole for nitifications only when notifications enabled Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Create clusterrolebinding for nitifications only when notifications enbaled Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Bump version in Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Update Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * Update Chart.yaml Signed-off-by: Denis Kadyshev <metajiji@gmail.com> --------- Signed-off-by: Denis Kadyshev <metajiji@gmail.com> * fix(argo-workflows): Fix outdated URL in values.yaml comments (argoproj#2328) * fix outdated link branch link Branch was renamed prior, redirects to main now Signed-off-by: Max! <admin@cloudydev.net> * Update Chart.yaml Signed-off-by: Max! <admin@cloudydev.net> * add to changelog Signed-off-by: Max! <admin@cloudydev.net> --------- Signed-off-by: Max! <admin@cloudydev.net> * chore(argo-workflows): Upgrade Argo Workflows to v3.5.1 (argoproj#2329) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (argoproj#2330) chore(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@47b15d5...e9fabac) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (argoproj#2331) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@be16258...a917fd1) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1 (argoproj#2332) Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/helm/chart-testing-action/releases) - [Commits](helm/chart-testing-action@b43128a...e6669bc) --- updated-dependencies: - dependency-name: helm/chart-testing-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(argo-cd): Upgrade Argo CD to 2.9.0 (argoproj#2318) Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * chore(github): Updated security documentation and CLOMonitor exemptions (argoproj#2333) * Updated security documentation and CLOMonitor exemptions Signed-off-by: Eddie Knight <knight@linux.com> * Added license scanning exepmtion Signed-off-by: Eddie Knight <knight@linux.com> * Added best practices badge to README Signed-off-by: Eddie Knight <knight@linux.com> --------- Signed-off-by: Eddie Knight <knight@linux.com> Co-authored-by: Jason Meridth <jmeridth@gmail.com> * fix(argo-workflows): Accept multi auth mode for server (argoproj#2336) * fix(argo-workflows): Accept multi auth mode for server Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): improve description of authMode Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-workflows): keep the older value valid for now as compatibility. Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(github): Add yu-cruco to * in CODEOWNERS (argoproj#2338) chore: Add yu-cruco to * in CODEOWNERS yu-cruco is now a maintainer and will be notified on all PRs - [x] moved CODEOWNERS into .github folder where it belongs Signed-off-by: jmeridth <jmeridth@gmail.com> * fix(argo-cd): Add permission for Applications in any namespace (argoproj#2341) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(argo-cd): Upgrade Argo CD to v2.9.1 (argoproj#2344) * chore(argo-rollouts): Bump rollouts to 1.6.1 (argoproj#2345) * Bump rollouts to 1.6.2 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump to 1.6.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Bump to 1.6.1 Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-rollouts): Bump rollouts to 1.6.2 (argoproj#2347) * fix(argo-workflows): Add parameters for tuning revisionHistoryLimit and emptyDir volumes (argoproj#2346) * fix(argo-workflows): Align version label (argoproj#2342) * fix(argo-workflows): Aligne version label Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-workflows): fix typo Signed-off-by: yu-croco <yu.croco@gmail.com> --------- Signed-off-by: yu-croco <yu.croco@gmail.com> * docs(github): typo fix in security.md (argoproj#2343) * typo fix Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> * Revert "typo fix" This reverts commit b02b2fb. Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> * typo fix in SECURITY.md Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> --------- Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> * chore(argo-workflows): Remove xip url from test to avoid confusion (argoproj#2350) * chore(argo-workflows): Remove xip url from test to avoid confusion Signed-off-by: Tim Collins <tim@thecollins.team> * Bump version Signed-off-by: Tim Collins <tim@thecollins.team> * More bumpings Signed-off-by: Tim Collins <tim@thecollins.team> * Tim can't type Signed-off-by: Tim Collins <tim@thecollins.team> * Swap to example.com - rfc2606 Signed-off-by: Tim Collins <tim@thecollins.team> --------- Signed-off-by: Tim Collins <tim@thecollins.team> * chore(argo-cd): Replace non-existing examples with official example domain (argoproj#2352) * chore(argo-cd): Upgrade Argo CD to v2.9.2 (argoproj#2353) Signed-off-by: yu-croco <yu.croco@gmail.com> * chore(github): Update SECURITY-INSIGHTS.yml to include security-contacts (argoproj#2356) * feat(argo-workflows): Make workflow controller ConfigMap optional (argoproj#2354) * chore(argo-workflows): Upgrade Argo Workflows to v3.5.2 (argoproj#2357) Signed-off-by: yu-croco <yu.croco@gmail.com> * fix(argo-rollouts): Update all rollout CRDs to match upstream (argoproj#2361) Signed-off-by: Abdulla Abdurakhmanov <me@abdolence.dev> * change image tag * change image tag --------- Signed-off-by: Fuochi <ffuochi@hotmail.com> Signed-off-by: yu-croco <yu.croco@gmail.com> Signed-off-by: Joonas Venäläinen <joonas.venalainen@anders.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: JesseBot <jessebot@linux.com> Signed-off-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Signed-off-by: Tamas <tamas@ujet.cx> Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> Signed-off-by: Andrew Hamilton <ahamilton55@gmail.com> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl> Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com> Signed-off-by: Pieter van der Giessen <pieter@pionative.com> Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com> Signed-off-by: Evgeny Khatko <owen.tko@gmail.com> Signed-off-by: Evgeny Khatko <ekhatko@paypal.com> Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com> Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Tim Collins <tim@thecollins.team> Signed-off-by: Jason Meridth <jmeridth@gmail.com> Signed-off-by: Denis Kadyshev <metajiji@gmail.com> Signed-off-by: Max! <admin@cloudydev.net> Signed-off-by: Eddie Knight <knight@linux.com> Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com> Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Signed-off-by: Abdulla Abdurakhmanov <me@abdolence.dev> Co-authored-by: Jason Meridth <jmeridth@gmail.com> Co-authored-by: Fuochi <ffuochi@hotmail.com> Co-authored-by: Jeongwon Song <46633758+jsong336@users.noreply.github.com> Co-authored-by: Aikawa <yu.croco@gmail.com> Co-authored-by: Joonas Venäläinen <38143731+joonvena@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Petr Drastil <petr.drastil@gmail.com> Co-authored-by: JesseBot <jessebot@linux.com> Co-authored-by: Gustav Kofoed Clausen <gustav@gustavclausen.com> Co-authored-by: Gustav Kofoed Clausen <gustavclausen@users.noreply.github.com> Co-authored-by: Tamas Szasz <szasz.tamas@gmail.com> Co-authored-by: Tamas <tamas@ujet.cx> Co-authored-by: Alexej Disterhoft <github@disterhoft.de> Co-authored-by: Andrew Hamilton <ahamilton55@gmail.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Mats Willemsen <60099717+ma-ts@users.noreply.github.com> Co-authored-by: sibucan <luis.ramirez.rivera92@gmail.com> Co-authored-by: Pieter <110168856+Pionerd@users.noreply.github.com> Co-authored-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com> Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com> Co-authored-by: Jonathan Raymond <jonwraymond@gmail.com> Co-authored-by: Ujin <592652+evgeniy-khatko@users.noreply.github.com> Co-authored-by: Evgeny Khatko <ekhatko@paypal.com> Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com> Co-authored-by: gussan <83329336+toyamagu-2021@users.noreply.github.com> Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: Denis Kadyshev <metajiji@gmail.com> Co-authored-by: Max! <admin@cloudydev.net> Co-authored-by: Eddie Knight <knight@linux.com> Co-authored-by: Matt Dainty <matt@bodgit-n-scarper.com> Co-authored-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com> Co-authored-by: qa-florian-wende <113123884+qa-florian-wende@users.noreply.github.com> Co-authored-by: Abdulla Abdurakhmanov <me@abdolence.dev>

fix(argo-workflows): Accept multi auth mode for server

6493904

Signed-off-by: yu-croco <yu.croco@gmail.com>

github-actions bot added size/S argo-workflows labels Nov 8, 2023

yu-croco commented Nov 8, 2023

View reviewed changes

yu-croco marked this pull request as ready for review November 8, 2023 07:03

yu-croco requested review from vladlosev, jmeridth and tico24 as code owners November 8, 2023 07:03

vladlosev reviewed Nov 8, 2023

View reviewed changes

chore(argo-workflows): improve description of authMode

3366c7c

Signed-off-by: yu-croco <yu.croco@gmail.com>

jmeridth reviewed Nov 8, 2023

View reviewed changes

yu-croco force-pushed the fix-auth-mode-type branch from 09c88d2 to ee198f8 Compare November 8, 2023 13:07

chore(argo-workflows): keep the older value valid for now as compatib…

f5aa459

…ility. Signed-off-by: yu-croco <yu.croco@gmail.com>

yu-croco force-pushed the fix-auth-mode-type branch from ee198f8 to f5aa459 Compare November 8, 2023 13:08

jmeridth approved these changes Nov 8, 2023

View reviewed changes

vladlosev approved these changes Nov 8, 2023

View reviewed changes

yu-croco merged commit 9840ebe into argoproj:main Nov 8, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(argo-workflows): Accept multi auth mode for server #2336

fix(argo-workflows): Accept multi auth mode for server #2336

yu-croco commented Nov 8, 2023 •

edited

Loading

yu-croco Nov 8, 2023

vladlosev Nov 8, 2023

yu-croco Nov 8, 2023

jmeridth Nov 8, 2023

yu-croco Nov 8, 2023

vladlosev left a comment

fix(argo-workflows): Accept multi auth mode for server #2336

fix(argo-workflows): Accept multi auth mode for server #2336

Conversation

yu-croco commented Nov 8, 2023 • edited Loading

yu-croco Nov 8, 2023

Choose a reason for hiding this comment

vladlosev Nov 8, 2023

Choose a reason for hiding this comment

yu-croco Nov 8, 2023

Choose a reason for hiding this comment

jmeridth Nov 8, 2023

Choose a reason for hiding this comment

yu-croco Nov 8, 2023

Choose a reason for hiding this comment

vladlosev left a comment

Choose a reason for hiding this comment

yu-croco commented Nov 8, 2023 •

edited

Loading