feat(argo-cd): add loadBalancerClass field for Service resource #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazal-k
force-pushed
the
load-balancer-class
branch
2 times, most recently
from
bcbefa4 to
9944969
Compare
gazal-k
changed the title
gazal-k
requested review from
jmeridth,
yu-croco,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
vladlosev
as code owners
|
Hi @gazal-k , thank you for your PR. |
gazal-k
force-pushed
the
load-balancer-class
branch
from
9944969 to
796286c
Compare
gazal-k
changed the title
Sure, done |
Most users of ArgoCD may use `Ingress` (and soon `HTTPRoute`), but for those who may want to use `Service` of type `LoadBalancer`, this would be useful. The `loadBalancerClass` field would allow for a `CloudProvider` agnostic way of offloading the reconciliation for Kubernetes Service resources of type `LoadBalancer` to an external controller. Signed-off-by: Gazal Gafoor <gazal.gafoor@rea-group.com>
gazal-k
force-pushed
the
load-balancer-class
branch
from
796286c to
3a2c7a5
Compare
mbevc1
approved these changes
Jun 17, 2024
yu-croco
approved these changes
Jun 18, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users of ArgoCD may use
Ingress(and soonHTTPRoute), but for those who may want to useServiceof typeLoadBalancer, this would be useful. TheloadBalancerClassfield would allow for aCloudProvideragnostic way of offloading the reconciliation for Kubernetes Service resources of typeLoadBalancerto an external controller.Checklist: