Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-rollouts): add loadBalancerClass field for Service resource #2772

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Jun 17, 2024

Most users of Argo Rollouts may use Ingress (and soon HTTPRoute), but for those who may want to use Service of type LoadBalancer, this would be useful. The loadBalancerClass field would allow for a CloudProvider agnostic way of offloading the reconciliation for Kubernetes Service resources of type LoadBalancer to an external controller.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Sorry, something went wrong.

Most users of ArgoCD may use `Ingress` (and soon `HTTPRoute`), but for those who may want to use `Service` of type `LoadBalancer`, this would be useful.
The `loadBalancerClass` field would allow for a `CloudProvider` agnostic way of offloading the reconciliation for Kubernetes Service resources of type `LoadBalancer` to an external controller.

Signed-off-by: Gazal Gafoor <gazal.gafoor@rea-group.com>
@gazal-k gazal-k force-pushed the load-balancer-class-rollouts branch from ffc1270 to aa8fc7d Compare June 19, 2024 23:41
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Gazal <gazal.gafoor@rea-group.com>
@gazal-k
Copy link
Contributor Author

gazal-k commented Aug 25, 2024

@yu-croco could you please review this? This is similar to #2769

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbevc1 mbevc1 merged commit 2df52cb into argoproj:main Aug 31, 2024
6 checks passed
@gazal-k gazal-k deleted the load-balancer-class-rollouts branch August 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants