chore(argo-workflows): update workflows version to most 3.0.7 #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3irdrobot
requested review from
oliverbaehler,
stefansedich,
vladlosev and
yann-soubeyrand
as code owners
Signed-off-by: Alex Sears <me@alexsears.com>
mkilchhofer
changed the title
mkilchhofer
requested changes
Jun 18, 2021
There was a problem hiding this comment.
Hello 👋 ,
Thanks for you contribution. I think we should also sync these changes here:
- feat(controller): Add liveness probe argo-workflows#5875
- fix(controller): Increase readiness timeout from 1s to 30s argo-workflows#6007
These changes were introduced in 3.0.4+
Very cool. I'll tackle this later tonight. |
Signed-off-by: Alex Sears <me@alexsears.com>
vladlosev
reviewed
Jun 18, 2021
| @@ -77,12 +77,16 @@ spec: | |||
| ports: | |||
| - name: metrics | |||
| containerPort: {{ .Values.controller.metricsConfig.port }} | |||
| - containerPort: 6060 | |||
| livenessProbe: | |||
There was a problem hiding this comment.
I think this should be configurable. In the current configuration the controller may be down up to four minutes until Kubernetes will detect that, and many people will want a faster reaction. The entire section may be put into the config, with the value moved into in values.yaml:
livenessProbe: {{ .Values.controller.livenessProbe | toYaml | nindent 12 }}
There was a problem hiding this comment.
good call. this has been updated
Signed-off-by: Alex Sears <me@alexsears.com>
mkilchhofer
approved these changes
Jun 25, 2021
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
…oj#811) * chore(argo-workflows): update workflows version to most 3.0.7 Signed-off-by: Alex Sears <me@alexsears.com> * chore(argo-worflows): update controller liveness probe Signed-off-by: Alex Sears <me@alexsears.com> * chore(argo-workflows): templatize controller liveness probe Signed-off-by: Alex Sears <me@alexsears.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.