Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(argo-workflows): update workflows version to most 3.0.7 #811

Merged
merged 4 commits into from
Jun 25, 2021
Merged

chore(argo-workflows): update workflows version to most 3.0.7 #811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ff50f9
chore(argo-workflows): update workflows version to most 3.0.7
w3irdrobot Jun 17, 2021
5bb12d0
chore(argo-worflows): update controller liveness probe
w3irdrobot Jun 18, 2021
1de4eb9
chore(argo-workflows): templatize controller liveness probe
w3irdrobot Jun 19, 2021
210c6aa
Merge branch 'master' into update-workflow-app-version
mkilchhofer Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,16 @@ spec:
ports:
- name: metrics
containerPort: {{ .Values.controller.metricsConfig.port }}
- containerPort: 6060
livenessProbe:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be configurable. In the current configuration the controller may be down up to four minutes until Kubernetes will detect that, and many people will want a faster reaction. The entire section may be put into the config, with the value moved into in values.yaml:

  livenessProbe: {{ .Values.controller.livenessProbe | toYaml | nindent 12 }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. this has been updated

httpGet:
port: metrics
path: {{ .Values.controller.metricsConfig.path }}
initialDelaySeconds: 30
periodSeconds: 30
port: 6060
path: /healthz
# Require three failures to tolerate transient errors.
failureThreshold: 3
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
{{- with .Values.images.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down